From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.devel Subject: Tree sitter: Should *-ts-modes derive from a common =?UTF-8?Q?base=3F?= Date: Tue, 21 Mar 2023 22:30:52 +1300 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18387"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Orcon Webmail To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 21 14:05:42 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pebgL-0004aa-Fu for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Mar 2023 14:05:41 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pebfb-0001vF-1f; Tue, 21 Mar 2023 09:04:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peYKc-0003jE-RZ for emacs-devel@gnu.org; Tue, 21 Mar 2023 05:31:02 -0400 Original-Received: from smtp-1.orcon.net.nz ([60.234.4.34]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peYKa-0002zG-VW for emacs-devel@gnu.org; Tue, 21 Mar 2023 05:31:02 -0400 Original-Received: from [10.253.37.70] (port=52068 helo=webmail.orcon.net.nz) by smtp-1.orcon.net.nz with esmtpa (Exim 4.90_1) (envelope-from ) id 1peYKS-00031d-Qz for emacs-devel@gnu.org; Tue, 21 Mar 2023 22:30:53 +1300 Original-Received: from ip-180-148-124-51.kinect.net.nz ([180.148.124.51]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Tue, 21 Mar 2023 22:30:52 +1300 X-Sender: psainty@orcon.net.nz X-GeoIP: -- Received-SPF: pass client-ip=60.234.4.34; envelope-from=psainty@orcon.net.nz; helo=smtp-1.orcon.net.nz X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 21 Mar 2023 09:04:52 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304644 Archived-At: WRT https://emacs.stackexchange.com/questions/76400/how-do-i-check-if-the-current-buffer-has-a-treesit-parser I wondered whether derived-mode-p could conveniently establish some kind of base ts-mode, but that doesn't appear to be the case (or at least not for the examples I looked at). I was pondering something like this: (define-derived-mode prog-ts-mode prog-mode "Prog(TS)" "Major mode for editing source code with tree-sitter support.") And then all the *-ts-mode derivatives of prog-mode changed like so: - (define-derived-mode cmake-ts-mode prog-mode "CMake" + (define-derived-mode cmake-ts-mode prog-ts-mode "CMake" The case I've spotted thus far which wouldn't work is the CSS modes, where we have this: (define-derived-mode css-base-mode prog-mode "CSS" (define-derived-mode css-mode css-base-mode "CSS" (define-derived-mode css-ts-mode css-base-mode "CSS" That could be refactored if this idea was a sensible one. Apologies if this has been discussed before... it seems like something which might have come up, but I couldn't find anything relevant. I'm not across the tree-sitter work in general though, and maybe this is a bad idea for some reason. -Phil