From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master 82ccc3a: ; Mention the previous change in NEWS Date: Tue, 8 Jun 2021 03:48:46 +0300 Message-ID: References: <83lf7lfwc8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26963"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 08 02:49:34 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqPvy-0006pL-NS for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Jun 2021 02:49:34 +0200 Original-Received: from localhost ([::1]:43836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqPvx-0003Jh-ML for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Jun 2021 20:49:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47030) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqPvI-0001Ht-4k for emacs-devel@gnu.org; Mon, 07 Jun 2021 20:48:52 -0400 Original-Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:37815) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lqPvG-0004G2-CM; Mon, 07 Jun 2021 20:48:51 -0400 Original-Received: by mail-wm1-x332.google.com with SMTP id f16-20020a05600c1550b02901b00c1be4abso796244wmg.2; Mon, 07 Jun 2021 17:48:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=stlpYVEM4uPMLmd0UxSqVOgcn61SypSDCFPudSxswQ4=; b=lyaZSvf+DqhR+womanUDoByIdsQYGA78/OGU6r54i4ZwlQSscPN//muUMbihVRLdaP mZAUWYaI7W7JxIUHFDjDxDqgNRjOc5EuojdeURLP/UpMISAiaSbZp798KngvNM6/Dp0i Gn7lhAi5kNqKTG66evXqzGbr1Rf7e9zLTwaCy2QDKmwgz52Pi1vI8yqicJVxDWmwD6/C N99FuweXudecgVhihsEGJXnLRFoZC0KO4YCpXRgk+m6hnC9KS4rnXhaWmJh8f3Ecmbo5 fPQIM18btjgC+FN+h+I1cX4ZG3S5krM/Oea1wuMr4BbMBAO7TvpnhsRxH9W26rjQjLtg Tvxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=stlpYVEM4uPMLmd0UxSqVOgcn61SypSDCFPudSxswQ4=; b=Aql4LAb+SkPUIc5y81sCkoCbvVI1/hEpZpZEdXlEgOk4CY/TD7Wj3Q5K70QvbSqVSN C07zQ8f+WJRuK5f5mglmkHEyd2R0VSE3evW2kG8XrUrTYBTDouUVeXlvtQWNILK9IIFc 2/W/KvqP5MFyrCRH0KUN/eS4TZAasnGGB8Q501jgOMphp6HDSeAwbwsNYYYHrmhdQ3rJ XNuedBdA9VC1ugP1fwxoGFu5uBo/ROowVnZyMDOY9Dn7QHCPfWsiZNJhzELc8eLyN4gT IIuizaygDrmfBL5uB4/qHnyFS0cMdqxuzGcI0wrm1lBprISY5LrKpnCf1ZmqAW9Wt/z/ XnSg== X-Gm-Message-State: AOAM530L+vosXn8x4Iiz0JWxd5Cpu3x+f0NuQb3TqGk05e1bd7rgCh2d CyH58PxofcISvA8JlnUhd1kZSMZZ13s= X-Google-Smtp-Source: ABdhPJweMHU04CNDxG/9AA0I0wi9cMdTiFQjLk5C5iM0NAk4bkNJo1VO+u0riS1MZiAOc48Fj4qc/w== X-Received: by 2002:a05:600c:35c1:: with SMTP id r1mr1442646wmq.181.1623113328338; Mon, 07 Jun 2021 17:48:48 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id i21sm1022231wmq.12.2021.06.07.17.48.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Jun 2021 17:48:47 -0700 (PDT) In-Reply-To: <83lf7lfwc8.fsf@gnu.org> Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=raaahh@gmail.com; helo=mail-wm1-x332.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270546 Archived-At: On 07.06.2021 19:55, Eli Zaretskii wrote: > I think it would be better to say something like > > *** Commands that use 'grep-find' now follow symlinks by default. Not exactly: going by the option's description in the manual, it follows symlinks for all arguments passed from the command line, but won't do that for any of the directories inside the searched directory that are also symlinks. > This affects the following commends: 'rgrep', ... > > This describes the change in terms of user commands, but can you help > me comping up with the list of affected commands? I don't think there's any visible change in behavior because of that change. It mostly mirrored the one in 2e55201b8085 for better/uniform approach to the problem. The latter change fixed ignore entries not being applied by the default implementation of project-files with certain old versions of 'find'. rgrep, which also has some ignores to handle, uses "." as the DIR argument, so it should see no change. xref-matches-in-directory has no known callers anymore, but any third-party code should see the IGNORES honored better with those old versions of 'find'. semantic/symref/grep.el doesn't use the "exclusions" argument. And as for following the symlinks, the existing users of grep-find-template, which were changed, previously used a different approach: having DIR end with '/' (hence the file-name-as-directory calls which were replaced with directory-file-name calls).