From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 82ccc3a: ; Mention the previous change in NEWS
Date: Tue, 8 Jun 2021 03:48:46 +0300 [thread overview]
Message-ID: <ff5db7e4-30f7-f0f2-1485-ab55d0f7fbba@yandex.ru> (raw)
In-Reply-To: <83lf7lfwc8.fsf@gnu.org>
On 07.06.2021 19:55, Eli Zaretskii wrote:
> I think it would be better to say something like
>
> *** Commands that use 'grep-find' now follow symlinks by default.
Not exactly: going by the option's description in the manual, it follows
symlinks for all arguments passed from the command line, but won't do
that for any of the directories inside the searched directory that are
also symlinks.
> This affects the following commends: 'rgrep', ...
>
> This describes the change in terms of user commands, but can you help
> me comping up with the list of affected commands?
I don't think there's any visible change in behavior because of that
change. It mostly mirrored the one in 2e55201b8085 for better/uniform
approach to the problem.
The latter change fixed ignore entries not being applied by the default
implementation of project-files with certain old versions of 'find'.
rgrep, which also has some ignores to handle, uses "." as the DIR
argument, so it should see no change.
xref-matches-in-directory has no known callers anymore, but any
third-party code should see the IGNORES honored better with those old
versions of 'find'.
semantic/symref/grep.el doesn't use the "exclusions" argument.
And as for following the symlinks, the existing users of
grep-find-template, which were changed, previously used a different
approach: having DIR end with '/' (hence the file-name-as-directory
calls which were replaced with directory-file-name calls).
next prev parent reply other threads:[~2021-06-08 0:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 16:55 master 82ccc3a: ; Mention the previous change in NEWS Eli Zaretskii
2021-06-08 0:48 ` Dmitry Gutov [this message]
2021-06-08 12:16 ` Eli Zaretskii
2021-06-08 14:46 ` Dmitry Gutov
2021-06-08 15:02 ` Eli Zaretskii
2021-06-08 15:21 ` Dmitry Gutov
2021-06-08 15:44 ` Eli Zaretskii
2021-06-08 15:56 ` Dmitry Gutov
2021-06-10 12:16 ` Eli Zaretskii
2021-06-10 12:26 ` Dmitry Gutov
2021-06-10 14:20 ` Eli Zaretskii
2021-06-10 17:06 ` Dmitry Gutov
2021-06-11 6:30 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff5db7e4-30f7-f0f2-1485-ab55d0f7fbba@yandex.ru \
--to=dgutov@yandex.ru \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).