From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: vertico Date: Sat, 10 Apr 2021 16:07:56 +0200 Message-ID: References: <87im4vglwv.fsf@gnu.org> <87sg3y7g7x.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20475"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 10 16:08:55 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVEIA-0005Dx-U5 for ged-emacs-devel@m.gmane-mx.org; Sat, 10 Apr 2021 16:08:54 +0200 Original-Received: from localhost ([::1]:40152 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVEI9-0008Sg-VA for ged-emacs-devel@m.gmane-mx.org; Sat, 10 Apr 2021 10:08:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVEHO-00082U-6J for emacs-devel@gnu.org; Sat, 10 Apr 2021 10:08:06 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:49049 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVEHL-0002Kx-Q6 for emacs-devel@gnu.org; Sat, 10 Apr 2021 10:08:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:To:Subject:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/ll9W2PXeVDSlSdoF3H9df6gK1SleK3SQimCzFsGPv0=; b=fLav/UOaAukbOKkURu1X3GJocU vVqTNsuXccS57Z50vsz70/qUy+RFC5PlIF4r8RYjt0oAE3Wt8EWLrQgYMMA51/NRhE6HG+2LbQETV 43RpWoWM3rrvqWxEdMkXgf8I2VxY6Xh4f1Wr6ijvRtvlYuQSgqRsX2nqUaElQYOWkkUs=; In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267824 Archived-At: On 4/10/21 3:34 PM, Stefan Monnier wrote: > Maybe a way to handle it "right" is for vertico to register an > `after-change-function` so as to detect also when the buffer's content is > modified outside of the normal commands (i.e. from a timer or process > filter). It'd probably be a bit messy, tho: it wouldn't want to refresh > the completion list right away, but there's no "obvious" later hook to > use (like `post-command-hook`) so it would need to detect when there's > not going to be a subsequent post-command-hook (i.e. when we're in > a timer or similar) and then probably fire its own timer to update the > completion list when the current processing is done. > > Or maybe it should use `after-change-function` to detect changes and > `pre-redisplay-functions` to update the list of completion. Yes, there are other hooks that could be used. I like to keep it simple as is and introduce nothing messy. I follow the design taken by Icomplete which works well. Daniel