From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.devel Subject: Re: contributing to Emacs Date: Sun, 18 Jun 2023 16:55:51 +0300 Message-ID: References: <83v8fnslfz.fsf@gnu.org> <87v8fnh1h2.fsf@web.de> <83mt0zs9rc.fsf@gnu.org> <0a968a4e1b267c0f15dd237e6ea12a709fc06d5e.camel@yandex.ru> <838rcisj7o.fsf@gnu.org> <6537fa5fa5c1fe8437ed99ee0988e35895f5a54b.camel@yandex.ru> <8423a35750d8d8e0437c7708f6b4d0bbdfdb7fe0.camel@yandex.ru> <87o7ldf7ky.fsf@web.de> <8cc19084ab18d0adb0f2cee4af14aa1b1d914a83.camel@yandex.ru> <87352p9izj.fsf@yahoo.com> <9db7822bba4d6002ff13e8d459e93d9972dd8627.camel@yandex.ru> <87y1kh7z1e.fsf@yahoo.com> <894396432f1746aed6428425a0210a1e5adba02f.camel@yandex.ru> <87h6r499wa.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23076"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.48.2 Cc: "Dr. Arne Babenhauserheide" , "Alfred M. Szmidt" , eliz@gnu.org, emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 18 15:56:19 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qAst8-0005mu-Qo for ged-emacs-devel@m.gmane-mx.org; Sun, 18 Jun 2023 15:56:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qAssp-0003Jy-2L; Sun, 18 Jun 2023 09:55:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAssn-0003HP-KV for emacs-devel@gnu.org; Sun, 18 Jun 2023 09:55:57 -0400 Original-Received: from forward502c.mail.yandex.net ([2a02:6b8:c03:500:1:45:d181:d502]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAssl-0004wS-Oo; Sun, 18 Jun 2023 09:55:57 -0400 Original-Received: from mail-nwsmtp-smtp-production-main-60.sas.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-60.sas.yp-c.yandex.net [IPv6:2a02:6b8:c14:150a:0:640:1aa5:0]) by forward502c.mail.yandex.net (Yandex) with ESMTP id 538325E70E; Sun, 18 Jun 2023 16:55:52 +0300 (MSK) Original-Received: by mail-nwsmtp-smtp-production-main-60.sas.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id ptfOrxWWta60-uflfo8pM; Sun, 18 Jun 2023 16:55:51 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1687096551; bh=ePeFZZ6N7B2R2OydOuk55hBirjGiIueFc6oRQiExnmQ=; h=References:Date:In-Reply-To:Cc:To:From:Subject:Message-ID; b=oIHlzQN1L61bsxfIQVfobxaqYjz1ppcLhicBzKXZ5+VX9oxgWXyI06RBdqthu7BEo WWT49YhaPkixvIEGYsbfOAiKeDGEG2tOuCnRMeb2e/srK5RC5B5NP3y3bbv6OxDP+R Gi3dCidLrC2yFjaIDzrnyPaldWnktG/ZAj4jAVG8= Authentication-Results: mail-nwsmtp-smtp-production-main-60.sas.yp-c.yandex.net; dkim=pass header.i=@yandex.ru In-Reply-To: <87h6r499wa.fsf@yahoo.com> Received-SPF: pass client-ip=2a02:6b8:c03:500:1:45:d181:d502; envelope-from=hi-angel@yandex.ru; helo=forward502c.mail.yandex.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306996 Archived-At: On Sun, 2023-06-18 at 21:29 +0800, Po Lu wrote: > Konstantin Kharlamov writes: >=20 > > On Sun, 2023-06-18 at 20:09 +0800, Po Lu wrote: > > > Konstantin Kharlamov writes: > > >=20 > > > > Ideally, each commit in the repository should contain minimal funct= ional > > > > changes. It allows for easier code review at the moment and for bet= ter > > > > figuring > > > > out why some change was done later in the life of the project. Usua= lly > > > > at > > > > this > > > > point I refer people to this old article from kernel HID subsystem > > > > maintainer > > > > and libinput creator > > > > http://who-t.blogspot.com/2009/12/on-commit-messages.html > > > > Old =E2=80=94 but gold! =F0=9F=98=84 > > >=20 > > > That's the purpose of ChangeLog, not the VCS. > > >=20 > > > > When project contributions are done via mailing list (such as kerne= l, > > > > gdb, > > > > gcc, > > > > and in the past were also Xorg and Mesa), you usually turn a number= of > > > > commits > > > > to separate patches and send them. E.g. here's one example: > > > > https://lore.kernel.org/dri-devel/20230612104658.1386996-1-tvrtko.u= rsulin@linux.intel.com/ > > > > it starts with a "zero patch" that is the title of the series, and = then > > > > individual patches follow. > > >=20 > > > Mesa and Linux are hardly all the world, and that wasn't my experienc= e > > > with GDB or GCC development. > >=20 > > I am not sure what you mean. Here's GCC ML with patches for the last mo= nth > > https://gcc.gnu.org/pipermail/gcc-patches/2023-May/thread.html=C2=A0You= can see > > they > > send series as well. Here's an arbitrary cover letter "zero patch" for = a > > series > > https://gcc.gnu.org/pipermail/gcc-patches/2023-May/618426.html >=20 > Where is it said that GCC development prefers changes to be submitted in > this format? Well, if you want to see the docs, then you can go here https://gcc.gnu.org/contribute.html#patches and you'll see that it starts w= ith words "Every patch", which implies that you send multiple patches rather th= an just one. "Multiple patches" is a series. Then if you look a bit further, you'll see this paragraph: > Series identifier > > The series identifier is optional and is only relevant if a number of pat= ches are needed in order to effect an overall change[=E2=80=A6] So yeah, here's an official text about patch series for GCC, as you wanted.