unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: rgm@gnu.org, silent2600@gmail.com, emacs-devel@gnu.org
Subject: Re: emacs26, ucs-normalize.el, Symbol’s function definition is void: regexp-opt-charset
Date: Thu, 14 Feb 2019 10:48:35 -0800	[thread overview]
Message-ID: <fed003e5-2d7c-5312-8ff7-4111a6cc71f0@cs.ucla.edu> (raw)
In-Reply-To: <83va1nnipe.fsf@gnu.org>

On 2/13/19 7:37 PM, Eli Zaretskii wrote:
>> -(eval-when-compile (require 'cl-lib))
>> +(eval-when-compile
>> +  (require 'cl-lib)
>> +  (require 'regexp-opt))
> I think it would be better to add the 'require' in the same
> eval-when-compile form which calls regexp-opt-charset.

There's more than one such form. At some point it's easier to treat 
regexp-opt functions like cl-lib functions, i.e., available to any code 
within an eval-when-compile in that module.




      reply	other threads:[~2019-02-14 18:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-11  1:21 emacs26, ucs-normalize.el, Symbol’s function definition is void: regexp-opt-charset hx
2019-02-11 16:39 ` Eli Zaretskii
2019-02-12  0:16   ` hx
2019-02-11 23:39 ` Paul Eggert
2019-02-12  3:35   ` Eli Zaretskii
2019-02-13 18:49     ` Paul Eggert
2019-02-13 19:18       ` Eli Zaretskii
2019-02-13 20:04       ` Glenn Morris
2019-02-13 20:15         ` Stefan Monnier
2019-02-14  3:32           ` Eli Zaretskii
2019-02-14  4:21             ` Stefan Monnier
2019-02-13 23:04         ` Paul Eggert
2019-02-14  3:37           ` Eli Zaretskii
2019-02-14 18:48             ` Paul Eggert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fed003e5-2d7c-5312-8ff7-4111a6cc71f0@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rgm@gnu.org \
    --cc=silent2600@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).