From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action' Date: Fri, 31 Dec 2021 19:42:28 +0100 Message-ID: References: <164073060906.21430.4993248796177370312@vcs2.savannah.gnu.org> <20211228223009.6D0BAC002EE@vcs2.savannah.gnu.org> <871r1v8nhf.fsf@gnus.org> <83ilv7jqm7.fsf@gnu.org> <6a9cd581-1630-4a95-62c4-419603561072@gmx.at> <3499cedf-b170-3045-873d-d45d2972ae13@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37886"; mail-complaints-to="usenet@ciao.gmane.io" To: sds@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 31 19:51:12 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n3Mzg-0009ge-B4 for ged-emacs-devel@m.gmane-mx.org; Fri, 31 Dec 2021 19:51:12 +0100 Original-Received: from localhost ([::1]:38470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n3Mze-0002xJ-9C for ged-emacs-devel@m.gmane-mx.org; Fri, 31 Dec 2021 13:51:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40218) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n3MrL-0005vg-9E for emacs-devel@gnu.org; Fri, 31 Dec 2021 13:42:35 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:41211) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n3MrI-0002kr-7v; Fri, 31 Dec 2021 13:42:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1640976149; bh=BDXO+Colg8/V6jxvYwbxLD1y4pWxMPvFBVv7ca1VMg4=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=K97Mo+D3OxmA9fjV9E+diMQQscRdHfYCRzbFuO+IIuO/zLHg4FfkSDngw/2QimtBl 38MvX0vkPPivk9EqjO9qg+j8sHJsHPNh1lfbO+EzE40EGaBZyjmrefHM+l/6H4UTf8 Qp/gluUHYzdEPDEH6DzXJzjwdzlr/G73NFlWnofY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.102] ([46.125.249.79]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MGQj7-1nD1uC164r-00GuFn; Fri, 31 Dec 2021 19:42:29 +0100 In-Reply-To: Content-Language: en-US X-Provags-ID: V03:K1:LqSkXwJe86eh8nczUxbk5hXFP5DNSxPaPy8bglY3uns3gOYmqgA DtN+pXRNi7fQHj5QRjXfbPZZXMzLOkVjq/dCs1XL72CuSUTwq9Q/ncvjNh0nKu7eFXlFyfh EYqMAxMAD78dg8nCaUhBmlPeUaUOgqy8F+1HhOyGaTGOgGPUNIqJDmOyd1hYVAm3ROmXQeD XhGZV/nCnVTZ5a6TlrzQA== X-UI-Out-Filterresults: notjunk:1;V03:K0:NFJx7kTtgqY=:joXWRyaK7tthkf5vUmy95X RzThz9o+TusfEzGzdpDUSQGFHSvBe/osbIXwH+WWxx5KNqOjmrXorijLxN5TIoZrxc743UGwt Xh/p957+qiiIZ7LjSsxNRYJ0Bz0lSSUH7BHH3SpKx75egsLSCUoa38DqD5zdRmmvA+pM8qg11 b0WO8BgTYCkVgWiS0M6wms6tr1zV+7+S/p5h4oY0J35wR7jcE8ci1eNiLO7BVQ06CHDzOhqOs s/7VgzkBTMKw581UfSH+d5NMugiw6VEJIcuEDTtURK6FJK6kMnszcRMOX4g/P0jUOC9dALDCH tuq+WjD1o2eMA5QskGbnRMU6ADL6P8snNG4quvqu3z8nMYmQFP/VL6GGWawusbzZJKSUMyQuu bIlhGFLRbLrTOK8w41/kLxrTNC9bd7MHoFSKzTMrbJDL7qH7CjAxNRAhu87FJMFd15g9zdVlW GQk3wd4HuquLmT71le67DY7NGjjZG5W4oVGYWSTAExqRFGJtu/+h1OZQncy6DBa88RZIrIMTa qF892IDdYZfxsPUbhG8RtHKWCQZGxOkx+GPv8x9CLxvbD/jYVQw8yGd7bm9Js4Ju3vacTBgdd wdomtoHW2p1GRynBMqEwTJI8QSWvLiv0rJp+BZJOa0JNdIOl1ydj4h6mRQ7YzdZviWzkAj8jc uRoahGv8ggdJGa77onSbY9Vlqow4uNJip09tM4jWTTkhNJzbdV7iywUYLGKAfCMPdQOk4B1aH rTwXWf1nVDubxjExoSz/lWwdX51WSMPqJ9YQAgm8hc/dySMJf89FnXzpfRhBTmuWcG0GM2ee Received-SPF: pass client-ip=212.227.17.21; envelope-from=rudalics@gmx.at; helo=mout.gmx.net X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:283762 Archived-At: > I cannot imagine a situation where I would want to use the same window > (i.e., show the shell buffer in the window from which I called shell). Neither can I. But in your OP your only concern was When I already have a window with shell, this patch creates a second such window. That's what my patch tried to fix. > IIUC, your patch will use the current window in some circumstances, It will use it unless the shell buffer is already shown in a window on the same frame. > and, since you want to use `display-buffer-reuseor-same-window' in > `shell'-like functions, I will not be able to avoid that. That's an exaggeration. You can always work around this problem via 'display-buffer-alist'. > I would much prefer that we use `pop-to-buffer' or `display-buffer' > everywhere (deprecating all those `pop-to-buffer-*' functions) I might agree. But we cannot simply convert everything that used 'switch-to-buffer' once (or still uses it) to use 'pop-to-buffer' instead. The greatest problem the 'display-buffer-alist' functionality had to deal with was to leave the default behavior unchanged while adding enough facilities so users could change the behavior to their like. That's also why I'd prefer to revert the original change and think about a better solution we can all live with for Emacs 29. > and let the _users_ decide how to display _all_ buffers using the standard > `display-buffer-alist' functionality. Deciding is not sufficient. Users have to customize it and you should have now noticed by yourself that dealing with 'display-buffer-alist' is not entirely trivial. martin