From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 1a6f595: * src/minibuf.c (read_minibuf): Add a FIXME comment. Date: Wed, 25 Apr 2018 12:30:35 -0700 Organization: UCLA Computer Science Department Message-ID: References: <20180424225022.24335.78516@vcs0.savannah.gnu.org> <20180424225023.4A3C620836@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------D477DEEE4BAAE1237388BAFE" X-Trace: blaine.gmane.org 1524684527 29957 195.159.176.226 (25 Apr 2018 19:28:47 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 25 Apr 2018 19:28:47 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 25 21:28:43 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fBQ5p-0007ac-0r for ged-emacs-devel@m.gmane.org; Wed, 25 Apr 2018 21:28:41 +0200 Original-Received: from localhost ([::1]:38684 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fBQ7t-0004uJ-Q3 for ged-emacs-devel@m.gmane.org; Wed, 25 Apr 2018 15:30:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34588) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fBQ7m-0004uB-Qx for emacs-devel@gnu.org; Wed, 25 Apr 2018 15:30:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fBQ7i-0000qt-Td for emacs-devel@gnu.org; Wed, 25 Apr 2018 15:30:42 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:57458) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fBQ7i-0000qI-J8 for emacs-devel@gnu.org; Wed, 25 Apr 2018 15:30:38 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id CD38B16005B; Wed, 25 Apr 2018 12:30:36 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 6gnRX7yRIziz; Wed, 25 Apr 2018 12:30:35 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id AC5E8160065; Wed, 25 Apr 2018 12:30:35 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Sa2_zwn92_fm; Wed, 25 Apr 2018 12:30:35 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 4E73C16005B; Wed, 25 Apr 2018 12:30:35 -0700 (PDT) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:224888 Archived-At: This is a multi-part message in MIME format. --------------D477DEEE4BAAE1237388BAFE Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 04/25/2018 04:59 AM, Stefan Monnier wrote: > Not sure what earlier time you're thinking of. My minibuffer-only frame > is still single-line, with no sign that it will grow a second line any > time soon. > > In any case, I don't think this buffer-local binding is right, so > I suggest removing it on `master`. I vaguely recall that the minibuffer used to have problems if you did stuff like (read-from-minibuffer "line1\nline2"). This now works and the minibuffer displays as multiple lines (and does not use backslash-n in the display). My memory of course could be faulty. Anyway, thanks for the second pair of eyes. I installed the attached into master and will close bug#31251. --------------D477DEEE4BAAE1237388BAFE Content-Type: text/plain; charset=UTF-8; name="0001-Don-t-set-print-escape-newlines-in-the-minibuffer.txt" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Don-t-set-print-escape-newlines-in-the-minibuffer.txt" RnJvbSA5MjBkMTA3ZDc4Y2JhNWMzOTA2NjFkN2E3ZjRiMWE4MjNkZGZlZjBkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBXZWQsIDI1IEFwciAyMDE4IDEyOjIwOjA0IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gPT9VVEYtOD9xP0Rvbj1FMj04MD05OXQ9MjBzZXQ9MjBwcmludC1lc2NhcGUtbmV3bGlu ZXM9MjBpPz0KID0/VVRGLTg/cT9uPTIwdGhlPTIwbWluaWJ1ZmZlcj89Ck1JTUUtVmVyc2lv bjogMS4wCkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250ZW50 LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0CgpUaGlzIGFwcGVhcnMgdG8gYmUgYW4gdW5uZWNl c3NhcnkgYW5kIHBvc3NpYmx5LWNvbmZ1c2luZwpyZXZlbmFudCBmcm9tIGFuY2llbnQgY29k ZSAoQnVnIzMxMjUxKS4gIFNlZSB0aHJlYWQgY29udGFpbmluZzoKaHR0cHM6Ly9saXN0cy5n bnUub3JnL3IvZW1hY3MtZGV2ZWwvMjAxOC0wNC9tc2cwMDY1NC5odG1sCiogc3JjL21pbmli dWYuYyAocmVhZF9taW5pYnVmKTogRG8gbm90IHNldCBwcmludC1lc2NhcGUtbmV3bGluZXMu Ciogc3JjL3ByaW50LmMgKHN5bXNfb2ZfcHJpbnQpOiBEbyBub3QgZGVmc3ltIHByaW50LWVz Y2FwZS1uZXdsaW5lcwpvciBwcmludC1lc2NhcGUtY29udHJvbC1jaGFyYWN0ZXJzLCBhcyB0 aGVzZSBzeW1ib2xzIGFyZSBub3QgdXNlZAppbiBDIGNvZGUuCi0tLQogc3JjL21pbmlidWYu YyB8IDcgLS0tLS0tLQogc3JjL3ByaW50LmMgICB8IDIgLS0KIDIgZmlsZXMgY2hhbmdlZCwg OSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvbWluaWJ1Zi5jIGIvc3JjL21pbmli dWYuYwppbmRleCAxMWIzZmUyYjljLi5jNDE5NThkODVmIDEwMDY0NAotLS0gYS9zcmMvbWlu aWJ1Zi5jCisrKyBiL3NyYy9taW5pYnVmLmMKQEAgLTU5NSwxMyArNTk1LDYgQEAgcmVhZF9t aW5pYnVmIChMaXNwX09iamVjdCBtYXAsIExpc3BfT2JqZWN0IGluaXRpYWwsIExpc3BfT2Jq ZWN0IHByb21wdCwKICAgWFdJTkRPVyAobWluaWJ1Zl93aW5kb3cpLT5oc2Nyb2xsID0gMDsK ICAgWFdJTkRPVyAobWluaWJ1Zl93aW5kb3cpLT5zdXNwZW5kX2F1dG9faHNjcm9sbCA9IDA7 CiAKLSAgLyogV2h5IGRvZXMgdGhpcyBjb2RlIHNldCBwcmludC1lc2NhcGUtbmV3bGluZXM/ ICBObyBjYWxsIHRvIEZwcmluMQotICAgICBvciB0byBGcHJpbnQgaXMgYW55d2hlcmUgaW4g c2lnaHQuICBGSVhNRTogRWl0aGVyIHJlbW92ZSB0aGUgbmV4dAotICAgICB0d28gbGluZXMg b2YgY29kZSBhbG9uZyB3aXRoIHRoaXMgY29tbWVudCwgb3IgcmVwbGFjZSB0aGlzCi0gICAg IGNvbW1lbnQgd2l0aCBhbiBleHBsYW5hdGlvbiBmb3Igd2h5IHRoZSB0d28gbGluZXMgYXJl IG5lZWRlZC4gICovCi0gIEZtYWtlX2xvY2FsX3ZhcmlhYmxlIChRcHJpbnRfZXNjYXBlX25l d2xpbmVzKTsKLSAgcHJpbnRfZXNjYXBlX25ld2xpbmVzID0gMTsKLQogICAvKiBFcmFzZSB0 aGUgYnVmZmVyLiAgKi8KICAgewogICAgIHB0cmRpZmZfdCBjb3VudDEgPSBTUEVDUERMX0lO REVYICgpOwpkaWZmIC0tZ2l0IGEvc3JjL3ByaW50LmMgYi9zcmMvcHJpbnQuYwppbmRleCBh OGJiYjlkMzdhLi43YzY4NTZhZjQ4IDEwMDY0NAotLS0gYS9zcmMvcHJpbnQuYworKysgYi9z cmMvcHJpbnQuYwpAQCAtMjQ0NywxMCArMjQ0Nyw4IEBAIHByaW9yaXRpZXMuICAqLyk7CiAg IGRlZnN1YnIgKCZTcmVkaXJlY3RfZGVidWdnaW5nX291dHB1dCk7CiAgIGRlZnN1YnIgKCZT cHJpbnRfcHJlcHJvY2Vzcyk7CiAKLSAgREVGU1lNIChRcHJpbnRfZXNjYXBlX25ld2xpbmVz LCAicHJpbnQtZXNjYXBlLW5ld2xpbmVzIik7CiAgIERFRlNZTSAoUXByaW50X2VzY2FwZV9t dWx0aWJ5dGUsICJwcmludC1lc2NhcGUtbXVsdGlieXRlIik7CiAgIERFRlNZTSAoUXByaW50 X2VzY2FwZV9ub25hc2NpaSwgInByaW50LWVzY2FwZS1ub25hc2NpaSIpOwotICBERUZTWU0g KFFwcmludF9lc2NhcGVfY29udHJvbF9jaGFyYWN0ZXJzLCAicHJpbnQtZXNjYXBlLWNvbnRy b2wtY2hhcmFjdGVycyIpOwogCiAgIHByaW50X3BydW5lX2NoYXJzZXRfcGxpc3QgPSBRbmls OwogICBzdGF0aWNwcm8gKCZwcmludF9wcnVuZV9jaGFyc2V0X3BsaXN0KTsKLS0gCjIuMTQu MwoK --------------D477DEEE4BAAE1237388BAFE--