From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.devel Subject: Re: "Can't find Hunspell dictionary" error (was Re: Emacs pretest 28.0.91 is out) Date: Fri, 14 Jan 2022 22:06:47 +1300 Message-ID: References: <5c74e0fb4c651733c0d8072f7cd40d06@webmail.orcon.net.nz> <878rvk3tw8.fsf@gmail.com> <87zgo02azu.fsf@gmail.com> <83tue73on6.fsf@gnu.org> <1cf6dd192736ae555734abb12bd17e9b@webmail.orcon.net.nz> <83mtjz3j44.fsf@gnu.org> <87lezj3f5d.fsf@gmail.com> <83ee5b3de7.fsf@gnu.org> <0f304fcc8959fd365e95ce36e42b4794@webmail.orcon.net.nz> <834k663i5r.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2313"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Orcon Webmail Cc: rpluim@gmail.com, stefan@marxist.se, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 14 10:12:06 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8Icv-0000VK-Fa for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Jan 2022 10:12:05 +0100 Original-Received: from localhost ([::1]:56338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8Icu-0005XP-8c for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Jan 2022 04:12:04 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45368) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8IXx-0007hF-RP for emacs-devel@gnu.org; Fri, 14 Jan 2022 04:06:57 -0500 Original-Received: from smtp-3.orcon.net.nz ([60.234.4.44]:35305) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8IXv-0002Ft-V0; Fri, 14 Jan 2022 04:06:57 -0500 Original-Received: from [10.253.37.70] (port=12069 helo=webmail.orcon.net.nz) by smtp-3.orcon.net.nz with esmtpa (Exim 4.90_1) (envelope-from ) id 1n8IXn-000330-Oq; Fri, 14 Jan 2022 22:06:47 +1300 Original-Received: from ip-139-180-65-103.kinect.net.nz ([139.180.65.103]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Fri, 14 Jan 2022 22:06:47 +1300 In-Reply-To: <834k663i5r.fsf@gnu.org> X-Sender: psainty@orcon.net.nz X-GeoIP: -- Received-SPF: pass client-ip=60.234.4.44; envelope-from=psainty@orcon.net.nz; helo=smtp-3.orcon.net.nz X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284736 Archived-At: On 2022-01-14 20:12, Eli Zaretskii wrote: > IOW, when you say "I wouldn't expect an absence of dictionaries to > cause those functions to fail", what do you expect from spell-checking > commands to do instead, when there are no dictionaries available to > them, except fail? `ispell-⁠valid-⁠dictionary-⁠list' isn't a spell-checking function per se, though -- it's a helper function for establishing which dictionaries are available for use *by* a spell-checking command. If a command to actually check some spelling was invoked and there were no dictionaries, then it would be fair to signal an error, but this error is happening when merely asking for a list of dictionaries, and an empty list is a valid list. If there are no valid dictionaries, `ispell-⁠valid-⁠dictionary-⁠list' should simply return an empty list. IIUC this is only happening if hunspell is the spell checker, so I think this should be considered a bug in the code for handling hunspell.