From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Bozhidar Batsov" Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] add outline regexp to ruby-mode Date: Fri, 08 Jul 2022 08:38:49 +0300 Message-ID: References: <867d4qvep9.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=befd8c5fbd944427a4d972f7090d1646 Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24169"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Cyrus-JMAP/3.7.0-alpha0-719-gc39a70fa89-fm-20220629.002-gc39a70fa To: "Emacs Devel" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 08 07:41:09 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9gji-00063y-Ng for ged-emacs-devel@m.gmane-mx.org; Fri, 08 Jul 2022 07:41:08 +0200 Original-Received: from localhost ([::1]:45698 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9gjg-0001m9-ER for ged-emacs-devel@m.gmane-mx.org; Fri, 08 Jul 2022 01:41:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9ghz-0000yJ-2J for emacs-devel@gnu.org; Fri, 08 Jul 2022 01:39:19 -0400 Original-Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:60061) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9ghw-0003Hn-3E for emacs-devel@gnu.org; Fri, 08 Jul 2022 01:39:18 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 0798932002E8 for ; Fri, 8 Jul 2022 01:39:10 -0400 (EDT) Original-Received: from imap43 ([10.202.2.93]) by compute5.internal (MEProxy); Fri, 08 Jul 2022 01:39:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=batsov.dev; h=cc :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1657258750; x=1657345150; bh=uWt8SSfgZ2 eFWb3K0kOyG9GCaaMm3PrtxvpOJgZFQr0=; b=ey+TkVFQho9SAYgNLRkgkuiNbQ lCo8SO7HzO3OeUl9H1cDL/e8hddKf54W7MHrtkBiUGCShQUSz5KT03z80AU7RVA3 +RVyTEOQHApt9CefTiKCC8L4IGF5rMyo3l1trh13NdHyTcO4QrBLBi2GK3N8WGts 7WP9RAErPbfCA57w/bA7hNMe8Vqf6C7A2UC/Kc1yskrsyGqEP281TNK0ImFu03ZE vZwAjkwWnBzFtOdHuasWRleKwRWpS1DgSGIV9qJjgs6QKRlel0a3e/LYqut5G9fz WHkPFlaFh0rJBj1gA7N5zf0Hwqu+e129kkd080T3O0t2KYP3u8aI5B/UKhEg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1657258750; x=1657345150; bh=uWt8SSfgZ2eFWb3K0kOyG9GCaaMm 3PrtxvpOJgZFQr0=; b=bRnbBVynVKPCxuYSRyqrJZNPigzAAWdgAzID5sTnsUCQ iYi/lrDDFGT+z6sFbuuKFX/EKtS2SnOFDQ/kVEZjuIjA/wk094eP5lEMWew0Ahb0 Lou+6/M9vJZI6/8GBpBiyRP76yqiXRIW+d/65v8q1IR0sFXyJ20tvDHv4xFraXpb UMFTbvVciaAVA5d3A8BOvbqnPRmcRETUtGiprSYpu+qtzKNlydIaCcsSbz74U+aW Pz0iqp5JpEDgYqJyG3OCZi07s5Qlu1BYBsmEhMFJJNQ8xrzaJoLeqI1ZafOSTZOa XaeQVfT2jYCUqjKYpEuc6hqicPsuJG9WMJ0xaymIyw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeiiedgleejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesrgdtreerreertdenucfhrhhomhepfdeuohii hhhiuggrrhcuuegrthhsohhvfdcuoegsohiihhhiuggrrhessggrthhsohhvrdguvghvqe enucggtffrrghtthgvrhhnpeegvdetfeekkeetieelffdtkedutdfhffefgedtvefhteef veejhffgtdekjeeiueenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpegsohiihhhiuggrrhessggrthhsohhvrdguvghv X-ME-Proxy: Feedback-ID: i025946a9:Fastmail Original-Received: by mailuser.nyi.internal (Postfix, from userid 501) id 4496D2D40071; Fri, 8 Jul 2022 01:39:10 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface In-Reply-To: Received-SPF: pass client-ip=64.147.123.25; envelope-from=bozhidar@batsov.dev; helo=wout2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291941 Archived-At: --befd8c5fbd944427a4d972f7090d1646 Content-Type: text/plain I'd still prefer the simpler regexp suggested by Juri, as it's more intention revealing, but I can live with using ruby-indent-beg-re as well. On Fri, Jul 8, 2022, at 4:12 AM, Dmitry Gutov wrote: > On 06.07.2022 11:06, Juri Linkov wrote: > > But now I noticed that actually if/unless/case/... in > > ruby-indent-beg-re has no effect on outlines, because > > they are on a separate regexp group. So using it for > > outline-regexp would be fine. Then I only suggest > > to add outline-level as well. > > If the result looks good to you, please go ahead. > > --befd8c5fbd944427a4d972f7090d1646 Content-Type: text/html
I'd still prefer the simpler regexp suggested by Juri, as it's more intention revealing, but I can live with using ruby-indent-beg-re as well.

On Fri, Jul 8, 2022, at 4:12 AM, Dmitry Gutov wrote:
On 06.07.2022 11:06, Juri Linkov wrote:
> But now I noticed that actually if/unless/case/... in
> ruby-indent-beg-re has no effect on outlines, because
> they are on a separate regexp group.  So using it for
> outline-regexp would be fine.  Then I only suggest
> to add outline-level as well.
< /div>

If the result looks good to you, please go ahead.



--befd8c5fbd944427a4d972f7090d1646--