From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: c-ts-mode: (eq treesit-font-lock-level 2) doesn't fontify parameter names. Date: Sat, 4 Feb 2023 20:44:52 +0200 Message-ID: References: <85fc0396-bf75-c059-3871-80a5cae8ab94@yandex.ru> <83bkm9ti2n.fsf@gnu.org> <838rhdthsl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7335"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: acm@muc.de, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 04 19:45:37 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pONXd-0001jz-4k for ged-emacs-devel@m.gmane-mx.org; Sat, 04 Feb 2023 19:45:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pONX2-00031l-Fy; Sat, 04 Feb 2023 13:45:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pONX0-00030f-Ay for emacs-devel@gnu.org; Sat, 04 Feb 2023 13:44:58 -0500 Original-Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pONWy-0006tv-9f; Sat, 04 Feb 2023 13:44:57 -0500 Original-Received: by mail-ej1-x62c.google.com with SMTP id gr7so23786907ejb.5; Sat, 04 Feb 2023 10:44:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=68XUUwKzeTSKyhX26DHc2B+2gPjzepEm3AEQW605f9E=; b=JF36TWiGnqMNOGy0cSSBQLdo7qa80N7d2z2uXlDpGGXuTpjFH1MZt6WeDEFB5eDyTJ 7SbCNXih3oTpUe7Htz75+h+REig0zXb6nBZ3JAdmAObEKaAu6ZXpLTuG2oqdyJSjQkH/ BqMdyegRRdynJOFyF26TqMee440w5Sc04ZGQKVErKlZUiyBupFgZQi1LmERM9YBTkEH6 +23xIZ4c0ii2f113+Sl3w78dPIOh7xqmCVQVJX9v1N6x0unRN/Z2Z0NKkKe3uqa5IVrQ mDuXO47NsdFYqFDJrzXTB5BUH1ScWGKqk+kdsUPEeeR5KqLClR5eZBlAeKnFLtiycUNn W1Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=68XUUwKzeTSKyhX26DHc2B+2gPjzepEm3AEQW605f9E=; b=Ksb4xgy6+zBCD2wXDdolRPSsddouDcQxRgYl5MCUIJ1jNrFvu78y3DkBjunXvPbsmS RjRSGDOzYbmy2QYiLqPbWWiLnW1e78AG5jZax1mmgOqkfWrMJ6fx0XpN95Z2A4b19m4c DuIgB6urYR9ge6MDnBUcDc8xtsesCLIEi3nz+d4/PuGWR1Eg5e5zppHPgrqQPp4lb1A0 P7APthSkpw1f2yENKTSLrDUAlehXxtFlyCcW4Irj81rmIX+Qg+IgCvSnEblagZNQ+ezP ts7Eno0YUOpbTbWrydZQB24LPXg+jB9hxecDlgdgtS2KwDIlNMyjHfRg3/eFwwy4W+f8 gNJA== X-Gm-Message-State: AO0yUKX1UFzoHtvQlHB6nmp2ijY+9uRg1SD1ymGpAFPF0giLblxFeucb NHos8T4c764K1DrNKp15aarQAW87FEo= X-Google-Smtp-Source: AK7set90Ch6i/ABrA1ehXLfknMJ6sy2dVbh9+QS7jyAGClCmoAcAByhFnPo75rhdD2yyEIzCPOOKbA== X-Received: by 2002:a17:906:c352:b0:878:8009:2177 with SMTP id ci18-20020a170906c35200b0087880092177mr14335755ejb.53.1675536294650; Sat, 04 Feb 2023 10:44:54 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id i19-20020a508713000000b004aaa5019bd7sm415742edb.44.2023.02.04.10.44.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Feb 2023 10:44:54 -0800 (PST) Content-Language: en-US In-Reply-To: <838rhdthsl.fsf@gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::62c; envelope-from=raaahh@gmail.com; helo=mail-ej1-x62c.google.com X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.09, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302977 Archived-At: On 04/02/2023 20:19, Eli Zaretskii wrote: >> Date: Sat, 04 Feb 2023 20:13:20 +0200 >> From: Eli Zaretskii >> Cc:acm@muc.de,emacs-devel@gnu.org >> >>> Date: Sat, 4 Feb 2023 19:32:11 +0200 >>> From: Dmitry Gutov >>> >>> On 04/02/2023 16:49, Alan Mackenzie wrote: >>>> Setting treesit-font-lock-level to 2 for c-ts-mode fontifies variable >>>> definitions, but not parameter definitions. >>> The patch below seems to fix that (the functionality was basically >>> implemented already). I suggest we install it on emacs-29, for >>> consistency with other modes, among other things. >> AFAIU, this patch will fontify variables in function parameter lists >> at level 1, not 2, but I don't mind. > Btw, we should probably do the same for C++ and Java. AFAICS, Java has this already, and c++-ts-mode will be affected by the proposed patch (c and c++ share c-ts-mode--font-lock-settings).