From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Miles Bader Newsgroups: gmane.emacs.devel Subject: Re: display-supports-face-attributes-p bug? Date: Fri, 10 Jun 2005 11:20:37 +0900 Message-ID: References: Reply-To: snogglethorpe@gmail.com, miles@gnu.org NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1118369882 20568 80.91.229.2 (10 Jun 2005 02:18:02 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 10 Jun 2005 02:18:02 +0000 (UTC) Cc: Eli Zaretskii , rms@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 10 04:17:59 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DgZ5b-0003x4-SF for ged-emacs-devel@m.gmane.org; Fri, 10 Jun 2005 04:17:44 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DgZCe-0007uS-2G for ged-emacs-devel@m.gmane.org; Thu, 09 Jun 2005 22:25:00 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DgZCL-0007rh-DI for emacs-devel@gnu.org; Thu, 09 Jun 2005 22:24:41 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DgZCJ-0007qs-SM for emacs-devel@gnu.org; Thu, 09 Jun 2005 22:24:40 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DgZCJ-0007q6-EH for emacs-devel@gnu.org; Thu, 09 Jun 2005 22:24:39 -0400 Original-Received: from [64.233.184.206] (helo=wproxy.gmail.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DgZ8h-00088G-LL for emacs-devel@gnu.org; Thu, 09 Jun 2005 22:20:55 -0400 Original-Received: by wproxy.gmail.com with SMTP id 63so60359wri for ; Thu, 09 Jun 2005 19:20:37 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=BZTLE1H3m5h2F35xWLA3zuJD7jQaSvMJyNWct9btVrHUWEQOSoRm60M/ri9LlpWTx4g9e/HyIQ5WMwynpO7S7efawA71pVZWy/ntvadjeFmMbpg0+faOrf2Z5DQWQUK6ZpXxVzjSncqZx1hF4NNgb+EAYgWJEzlMxx/2ZKCbQgQ= Original-Received: by 10.54.1.39 with SMTP id 39mr86671wra; Thu, 09 Jun 2005 19:20:37 -0700 (PDT) Original-Received: by 10.54.19.31 with HTTP; Thu, 9 Jun 2005 19:20:37 -0700 (PDT) Original-To: James Cloos In-Reply-To: Content-Disposition: inline X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:38486 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:38486 On 6/10/05, James Cloos wrote: > But note that it is possible that real underlining will be added in > the future for those that use a framebuffer console. It may even > already work on non-x86, non-VGA hardware -- such as sun or ppc > hardware -- but I do not have such a box to check. Unless there's some way Emacs can find out the true state of things, there's not much that can be done. If it's impossible to tell whether there's correct underlining support, it seems safer to assume there's not -- or at the least don't _advertise_ that there is. In other words, probably the right thing to do is still emit enter/exit-underlining escape codes for underlined faces, but have `display-supports-face-attribute-p' return nil for the :underline attribute. It also seems reasonable to base the default Emacs behavior on the current state of the most popular platform, in cases where there's no way of distinguishing. [Of course if we add a hack to override terminfo, it would also be good to have a way for the user to override that.] -Miles --=20 Do not taunt Happy Fun Ball.