From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Miles Bader Newsgroups: gmane.emacs.devel Subject: Re: Changes to gdb-ui.el Date: Mon, 21 Mar 2005 07:39:59 +0900 Message-ID: References: <16958.302.32187.274750@farnswood.snap.net.nz> Reply-To: snogglethorpe@gmail.com, miles@gnu.org NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1111358384 15735 80.91.229.2 (20 Mar 2005 22:39:44 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 20 Mar 2005 22:39:44 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 20 23:39:44 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DD93w-0006cP-EK for ged-emacs-devel@m.gmane.org; Sun, 20 Mar 2005 23:38:24 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DD9Ku-00084M-V8 for ged-emacs-devel@m.gmane.org; Sun, 20 Mar 2005 17:55:56 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DD9Kf-00082Z-T5 for emacs-devel@gnu.org; Sun, 20 Mar 2005 17:55:43 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DD9Ka-0007zd-Ld for emacs-devel@gnu.org; Sun, 20 Mar 2005 17:55:37 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DD9Ka-0007zT-Is for emacs-devel@gnu.org; Sun, 20 Mar 2005 17:55:36 -0500 Original-Received: from [64.233.184.203] (helo=wproxy.gmail.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DD95T-00045Z-P8 for emacs-devel@gnu.org; Sun, 20 Mar 2005 17:39:59 -0500 Original-Received: by wproxy.gmail.com with SMTP id 40so264008wri for ; Sun, 20 Mar 2005 14:39:59 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=Viw4xPao2PMNlyca54vJaBT1wtmTzj+QkGAJn13Tl4DyMv5PaEJv7Y1Z/J9xoBeou+sFSQoeBY9Y/Vs2L6Pt+EiB5XWtRiWyaYMsevZVP0BDtTjcsJRF0ZoqHnt8PZju6eSyzGjUVEz/NFlKLfkOMPLk4wBkC4DtMOpPqmoIrgI= Original-Received: by 10.54.17.73 with SMTP id 73mr452807wrq; Sun, 20 Mar 2005 14:39:59 -0800 (PST) Original-Received: by 10.54.19.70 with HTTP; Sun, 20 Mar 2005 14:39:59 -0800 (PST) Original-To: Nick Roberts In-Reply-To: <16958.302.32187.274750@farnswood.snap.net.nz> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: news.gmane.org gmane.emacs.devel:34860 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:34860 On Mon, 21 Mar 2005 11:03:10 +1200, Nick Roberts wrote: > I don't think using breakpoint faces in text-mode quite works. On a basic > xterm, an enabled breakpoint (letter 'B') stands out clearly in red, but > as disabled breakpoint (letter 'b') disappears completely. It works correclty on the linux console; it may be face definitions need tweaking for "low-color" terminals (this can be done using the conditional facility of the face definition language). > the subtleties of faces but maybe grey60 gets 'rounded' to white on an xterm > with 8/16 colours. Yes, this is probably what's happening. > Also the background of the face doesn't always match the > background of the terminal (I have found particularly so for a gnome-terminal). Ok; probably the `:inherit fringe' should be used only for bitmaps (is it even useful for them? I though fringe stuff would get merged with the fringe face anyway). > In X, enabled/disabled breakpoints are distinguished by colour alone, the > icons having the same shape both in the margin and in the fringe. In text > mode the breakpoint state is already distinguished by the case of the letter > (B/b) so the same colour can be used. To help it stand out from the text, > I guess this color could be red in both cases, a color which I presume is > available on many terminals. Note that I made this change because I was setting breakpoints on a tty and couldn't see them very well; having them displayed in bold red _really_ helps. I'll give the faces a tweak to reflect the above points. -Miles -- Do not taunt Happy Fun Ball.