From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Miles Bader Newsgroups: gmane.emacs.devel Subject: Re: VM and find-face Date: Fri, 7 Jan 2005 07:11:46 +0900 Message-ID: References: <16861.24082.521425.279155@notch.amtp.cam.ac.uk> <16861.45273.244285.279310@cocoa.WonderWorks.COM> Reply-To: snogglethorpe@gmail.com, miles@gnu.org NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1105049599 25612 80.91.229.6 (6 Jan 2005 22:13:19 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 6 Jan 2005 22:13:19 +0000 (UTC) Cc: Stephen Eglen , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 06 23:13:02 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CmfsL-0003bo-00 for ; Thu, 06 Jan 2005 23:13:01 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Cmg3f-0006Lm-8C for ged-emacs-devel@m.gmane.org; Thu, 06 Jan 2005 17:24:43 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1Cmg2v-0005pZ-1O for emacs-devel@gnu.org; Thu, 06 Jan 2005 17:23:57 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1Cmg2s-0005oL-1a for emacs-devel@gnu.org; Thu, 06 Jan 2005 17:23:54 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Cmg2r-0005lX-Px for emacs-devel@gnu.org; Thu, 06 Jan 2005 17:23:53 -0500 Original-Received: from [64.233.184.202] (helo=wproxy.gmail.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Cmfr9-0000Sz-2Y for emacs-devel@gnu.org; Thu, 06 Jan 2005 17:11:47 -0500 Original-Received: by wproxy.gmail.com with SMTP id 49so780474wri for ; Thu, 06 Jan 2005 14:11:46 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=KalfPC/GdFovF2Z/myHB1C228Fzg0461eAVihM289YTaAgkS+VvDj6+0LQfHUEUsxYdryBFnHFfonba83oillmVCEfYHlVPAqE1JWHH0k70HWGPcbEPaBJw8mF+tXn6IzIIWTcy70JFL+kdv5thwlIV7gQJXUILWbs6ZRJ7VXqs= Original-Received: by 10.54.20.27 with SMTP id 27mr440020wrt; Thu, 06 Jan 2005 14:11:46 -0800 (PST) Original-Received: by 10.54.19.32 with HTTP; Thu, 6 Jan 2005 14:11:46 -0800 (PST) Original-To: Kyle Jones In-Reply-To: <16861.45273.244285.279310@cocoa.WonderWorks.COM> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:31980 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:31980 I sent this message to a different mailing list: On Thu, 06 Jan 2005 15:05:57 +0000, Glenn Morris wrote: > The new function find-face is incompatible with the XEmacs version, > and therefore breaks existing package code that tries to handle both > Emacs flavours. > > The GNU Emacs version throws an error for an unknown face: > > (find-face 'made-up-face) Yes, the new function `find-face' appears to be a completely different function than the xemacs `find-face' function; it seems to be an analogue to `find-function', for finding the source code definition of a face. I'm not sure that this is all that useful a function anyway -- the source code of a defface doesn't really offer much over the face definition displayed by custom or the like; unlike a function or variable, defface definitions are almost always "static" (don't use a run-time calculated value) and rarely have any comments. Compatibility with xemacs seems more important. Perhaps the function could be renamed `find-defface' or `find-face-definition' instead; those names are slightly inconsistent with other such functions, but maybe it doesn't matter very much for a function that will likely be used mostly by clicking on a button in a *Help* buffer. -Miles