From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 2349f1d: Turn global-eldoc-mode into a globalized minor mode
Date: Wed, 31 May 2017 01:37:17 +0300 [thread overview]
Message-ID: <fbe85bba-3448-5c01-73aa-6474b672201f@yandex.ru> (raw)
In-Reply-To: <jwvh903gf63.fsf-monnier+emacsdiffs@gnu.org>
On 5/30/17 7:09 AM, Stefan Monnier wrote:
>> ((memq eldoc-documentation-function '(nil ignore))
> [...]
>> + (unless (memq eldoc-documentation-function '(nil ignore))
>
> It'd probably be best to move this out into its own function so if we
> ever change the test at one spot, we also change the other
> spot accordingly.
OK, done.
Thinking about this, though, I'm not sure this is ideal.
First, this setup is sensitive to the order in which minor modes are
enabled. Which is, in theory, arbitrary.
Second, suppose the user enables an eldoc-enabling-mode manually with
'M-x'. They'll have to 'M-x eldoc-mode' manually afterwards for the
desired effect.
next prev parent reply other threads:[~2017-05-30 22:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170529235539.23360.19169@vcs0.savannah.gnu.org>
[not found] ` <20170529235540.48D1C20ACA@vcs0.savannah.gnu.org>
2017-05-30 4:09 ` [Emacs-diffs] master 2349f1d: Turn global-eldoc-mode into a globalized minor mode Stefan Monnier
2017-05-30 22:37 ` Dmitry Gutov [this message]
2017-05-31 11:54 ` Stefan Monnier
2017-05-31 12:15 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbe85bba-3448-5c01-73aa-6474b672201f@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).