unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Jason Kim <jason.w.kim@icloud.com>
To: Eli Zaretskii <eliz@gnu.org>, michael.albinus@gmx.de
Cc: emacs-devel@gnu.org, shivers@cs.cmu.edu, jason.kim@revtera.com
Subject: Re: Small shell-mode patch to handle auto-cd (e.g. shells like zsh)
Date: Fri, 7 May 2021 09:35:16 -0700	[thread overview]
Message-ID: <fb8c004a-5ec4-fa33-c1ba-0e5682a46530@icloud.com> (raw)
In-Reply-To: <83v97we0ey.fsf@gnu.org>


Working on it now,  Expect the git format-patch shortly
But just to set the stage.... a few comments.

On 5/6/21 1:23 AM, Eli Zaretskii wrote:
> 
>   . A few comments on the code itself:
> 
>> +(defvar shell-has-auto-cd nil
>> +  "if set to true, shell-mode assumes that a command that resolves to a directory
>> +is an implicit cd command. Useful for shells like zsh that has this feature.")
> 
> This should be a defcustom, so that users could customize it easily.
> 
done.

> The first line of the doc string should be a single complete
> sentence.  Something like this:
> 
>    If non-nil, `shell-mode' will automatically process implicit \"cd\" commands.

Yep that's lot better :-) thanks!

> 
> (Then in the following text of the doc string explain what does
> "implicit cd command" mean in this context.)
> 
> Should this variable's value be computed automatically based on the
> shell's name?

I don't think so... If only because its an option that needs enabling in 
zsh as well?

> 
>> -		end cmd arg1)
>> +		end cmd arg1 cmdS)
> 
> I wonder if you could find a more descriptive name for the cmdS
> variable.

cmdS --> cmd-subst-fn

 > michael.albinus@gmx.de writes
 >- Several different shells could be used in an Emacs session, depending
 >  where you run the shell, locally or on a remote host. So it might be
 >  problematic to have just one fixed global value.

I'm confused...?
Would making the variable buffer-local in a user's .emacs address this?

dir tracking (for things like auto completion) never worked for me if I 
ssh into a different host from emacs-shell.
(maybe because pattern globbing rules are more complex (optionally) in zsh?)
What am I missing here?

Can we skip this issue for now? (or does making the var buffer-local get 
around it?)

Thank!!!
-jason



  reply	other threads:[~2021-05-07 16:35 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-05 19:55 Small shell-mode patch to handle auto-cd (e.g. shells like zsh) Jason Kim
2021-05-06  8:10 ` Michael Albinus
2021-05-06  8:23 ` Eli Zaretskii
2021-05-07 16:35   ` Jason Kim [this message]
2021-05-07 16:51     ` Jason Kim
2021-05-15  8:20       ` Eli Zaretskii
2021-05-24 17:15         ` Jason Kim
2021-05-24 17:20           ` Jason Kim
2021-05-25  7:38             ` Michael Albinus
2021-05-27 17:09               ` Jason Kim
2021-06-09 11:03                 ` Michael Albinus
2021-05-07 17:39     ` Michael Albinus
2021-05-08  6:36     ` Eli Zaretskii
2021-05-08 16:39       ` Jason Kim
2021-05-08 16:48         ` Eli Zaretskii
2021-05-08 17:19           ` Jason Kim
2021-05-08 17:58             ` Jason Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb8c004a-5ec4-fa33-c1ba-0e5682a46530@icloud.com \
    --to=jason.w.kim@icloud.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jason.kim@revtera.com \
    --cc=michael.albinus@gmx.de \
    --cc=shivers@cs.cmu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).