From: Dmitry Gutov <dmitry@gutov.dev>
To: Robert Pluim <rpluim@gmail.com>, emacs-devel@gnu.org
Cc: Po Lu <luangruo@yahoo.com>
Subject: Re: master 1aa83da46d1 2/2: ; * etc/NEWS: Rename read-process-output-fast here also.
Date: Tue, 11 Jun 2024 15:28:44 +0300 [thread overview]
Message-ID: <fb40ff9a-6b82-4a68-8e2d-587e524555a3@gutov.dev> (raw)
In-Reply-To: <87tthzg9qi.fsf@gmail.com>
On 11/06/2024 11:32, Robert Pluim wrote:
> Po Lu> -To undo the change, set 'read-process-output-fast' to nil.
> Po Lu> +To undo the change, set 'fast-read-process-output' to nil.
>
> I realise weʼve renamed this one already, but would it not make more
> sense for the variable to be called something starting with
> 'process-', such as 'process-fast-read-output'? Thatʼs in line with
> other variables affecting the processes process data, such as
> `process-adaptive-read-buffering'.
The idea behind this name was to match one specific C function (which
might be familiar to many who read Emacs's code), but I don't have a
strong opinion either way. process-read-output-fast, maybe?
Also note that both previous names have been already mentioned in
bug#71452 comments, so I suppose the new one should be mentioned too, in
order to avoid keeping an outdated source on that subject.
next prev parent reply other threads:[~2024-06-11 12:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <171808806905.4080.7963946550063771118@vcs2.savannah.gnu.org>
[not found] ` <20240611064113.5E651C1FB57@vcs2.savannah.gnu.org>
2024-06-11 8:32 ` master 1aa83da46d1 2/2: ; * etc/NEWS: Rename read-process-output-fast here also Robert Pluim
2024-06-11 8:35 ` Po Lu
2024-06-11 8:36 ` Po Lu
2024-06-11 12:28 ` Dmitry Gutov [this message]
2024-06-11 12:35 ` Robert Pluim
2024-06-11 13:03 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb40ff9a-6b82-4a68-8e2d-587e524555a3@gutov.dev \
--to=dmitry@gutov.dev \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).