From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: vertico Date: Sat, 10 Apr 2021 11:33:32 +0200 Message-ID: References: <87im4vglwv.fsf@gnu.org> <87sg3y7g7x.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36928"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 10 11:34:43 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVA0p-0009TF-Hx for ged-emacs-devel@m.gmane-mx.org; Sat, 10 Apr 2021 11:34:43 +0200 Original-Received: from localhost ([::1]:59924 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVA0o-00056c-K8 for ged-emacs-devel@m.gmane-mx.org; Sat, 10 Apr 2021 05:34:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46168) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lV9zo-0004Wh-B7 for emacs-devel@gnu.org; Sat, 10 Apr 2021 05:33:40 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:51023 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lV9zl-0005Bj-Vu; Sat, 10 Apr 2021 05:33:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zDOFtADOes4NDVrwRpV0cuI3uU0PFgjEqlzbVGR1oT0=; b=QJDFQTenvqSmtEdIZW2J41xJ6p hNgGGFyOjnbaJip9Pl5TxcOnC/LuMB0ObPmU7wdYNhIABPGQeTliluVbA/X5oJA3NkMsKJ1rCCF9P X4SsORGXO1MKRVDDrfdeFGwVu8s1qz3oPh7Rhh+WfdeHQBCT8uae0ee/LUfPTNjfGi5s=; In-Reply-To: <87sg3y7g7x.fsf@gnu.org> Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267788 Archived-At: On 4/10/21 9:17 AM, Tassilo Horn wrote: >> But note that Vertico is fully compatible with default completion, so >> as you observed you can just use `minibuffer-complete`. If you bind >> `minibuffer-complete` to the `vertico-map` it will work. See >> https://github.com/minad/vertico#keymap. >> >> Is that good enough or do you have something else in mind? > > It's just almost good enough. It completes correctly but the candidates > are not refreshed. For example, with find-file, it might complete > uniquely to a directory but still display the siblings of that directory > rather than its contents. That's why I've sneaked in a call to > `vertico--exhibit' in my `th/vertico--complete' command. If you bind `minibuffer-complete` to a keybinding in `vertico-map` it will automatically update the UI via the `post-command-hook`, which calls `vertico--exhibit`. I have checked your aggressive-completion package and there you are using a timer. I wonder why you are doing that (Performance issues?). Wouldn't it be better to use an `after-change-function` or a `post-command-hook`? If you use a `post-command-hook`, it will work automatically with Vertico as long as your `post-command-hook` which aggressively calls `minibuffer-complete` runs before my `vertico--exhibit` hook. If you continue to use a timer, you necessarily have to inform the Vertico UI that something has changed. As I said, Vertico only updates itself via the `post-command-hook` and does not detect other changes. So as things stand, there is no other way than calling `vertico--exhibit` manually. With Icomplete the situation should be the same, see `icomplete-exhibit`. If your package works well with Icomplete it should also work well with Vertico and vice versa. Daniel Mendler