From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Preview: portable dumper Date: Tue, 20 Feb 2018 13:51:16 -0800 Organization: UCLA Computer Science Department Message-ID: References: <1775923222.898447.1518559575706@mail.libero.it> <277032065.898859.1518560883271@mail.libero.it> <1456022824.1085831.1518815658356@mail.libero.it> <46535781-d5c2-fee8-05aa-37a29988ce86@dancol.org> <83a7w8c7yg.fsf@gnu.org> <86eflg8vqi.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1519163406 5488 195.159.176.226 (20 Feb 2018 21:50:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 20 Feb 2018 21:50:06 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 To: Andy Moreton , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 20 22:50:02 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eoFnV-0001Ae-IH for ged-emacs-devel@m.gmane.org; Tue, 20 Feb 2018 22:50:01 +0100 Original-Received: from localhost ([::1]:57930 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eoFpX-0007Oy-OZ for ged-emacs-devel@m.gmane.org; Tue, 20 Feb 2018 16:52:07 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49693) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eoFoo-0007Oc-IF for emacs-devel@gnu.org; Tue, 20 Feb 2018 16:51:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eoFol-0002TE-Dy for emacs-devel@gnu.org; Tue, 20 Feb 2018 16:51:22 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:36932) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eoFol-0002Su-77 for emacs-devel@gnu.org; Tue, 20 Feb 2018 16:51:19 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E86D21606B2; Tue, 20 Feb 2018 13:51:17 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id g61lkewjGSuQ; Tue, 20 Feb 2018 13:51:17 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 24494160980; Tue, 20 Feb 2018 13:51:17 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 2TYVxK1-yM52; Tue, 20 Feb 2018 13:51:17 -0800 (PST) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 06AC61606B2; Tue, 20 Feb 2018 13:51:17 -0800 (PST) In-Reply-To: <86eflg8vqi.fsf@gmail.com> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222950 Archived-At: On 02/19/2018 02:23 PM, Andy Moreton wrote: > Comments mentioning MAX_RW_COUNT show that somebody checked an invariant > when writing the comment, but they do not guarantee that the invariant > will continue to be maintained in future versions of emacs. A check that > can be enforced by the compiler is preferable. That "somebody" was me. That is, I looked at all the callers of these functions and checked that none of them go above MAX_RW_COUNT. That being said, it doesn't hurt to put in an eassert to check this as well (thanks, Eli). It would be a pain to check all the callers at compile-time, alas. > Is there a gnulib replacement for read() that works for emacs, so that > we could use the proper prototype even on Windows ? There is. However, the Gnulib 'read' does some stuff that the Emacs 'read' doesn't (and vice versa). Nobody has taken the time to try to unify them, and it's possible that unifying them would not be a good idea overall.