From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: Re: scratch/igc 26ea4b462a0: Fix GTK-related MPS crashes Date: Tue, 09 Jul 2024 13:58:06 +0000 Message-ID: References: <172010929191.25736.12718952666511242363@vcs2.savannah.gnu.org> <20240704160812.55782C2BC72@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4779"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 09 16:12:17 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sRBZn-0000sl-SZ for ged-emacs-devel@m.gmane-mx.org; Tue, 09 Jul 2024 16:12:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRBYz-0002Ri-U5; Tue, 09 Jul 2024 10:11:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRBMM-0005FM-P4 for emacs-devel@gnu.org; Tue, 09 Jul 2024 09:58:22 -0400 Original-Received: from mail-4316.protonmail.ch ([185.70.43.16]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRBML-0004c2-19 for emacs-devel@gnu.org; Tue, 09 Jul 2024 09:58:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1720533492; x=1720792692; bh=5aRsLyNrmMxHI7uaADyUfCpP3mtA0yxgpRX6Bt9EknY=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=fg5gKNGEE+EuK9MloLEHzjHmuuJNy6mBB5Ata8hCS/u+wP9zO0jvkg1RrPrb9E8TB P3zdt8FIskQ/77Cd9Ty0icUEqZdNiCXJFUixvFs6ni0w2EvNN7QkZETvOojyOm2H23 p5M7bojTR/7tRZDLUIOfLAY/OsUvhjZ6h+6YztyFEWOWKWnenubdPncyASVV1qQ1n5 KLWd7MgM34Pxs6DIz32GnMPCJsTqjtpO6/yF3FzJAQ9p1Mg4pPT+rFnx5kUvoo4zZO z5aT4+PoI89/p/ypO4r1D4QsiQRldYU4Ef7FUHXsyqWT9SD59LxDMBx61T7mV9sIcS 2z2HiuBfqIXFw== In-Reply-To: Feedback-ID: 112775352:user:proton X-Pm-Message-ID: d609af8bcbc4c486b674357131820bc36805595c Received-SPF: pass client-ip=185.70.43.16; envelope-from=pipcet@protonmail.com; helo=mail-4316.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 09 Jul 2024 10:11:14 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321564 Archived-At: On Tuesday, July 9th, 2024 at 12:28, Andrea Corallo wrot= e: > Pip Cet via Mailing list for Emacs changes emacs-diffs@gnu.org writes: >=20 > > branch: scratch/igc > > commit 26ea4b462a031a8e57ed3ef8f8d76ba3f88b1372 > > Author: Pip Cet pipcet@protonmail.com > > Commit: Pip Cet pipcet@protonmail.com > >=20 > > Fix GTK-related MPS crashes > >=20 > > * src/gtkutil.c (free_glib_user_data): New function. > > (xg_list_insert, xg_list_remove): Conditionalize on !HAVE_MPS. > > (qttip_cb, xg_create_frame_widgets) > > (xg_create_frame_outer_widgets, create_dialog) > > (make_cl_data, unref_cl_data, xg_mark_data) > > (menuitem_highlight_callback, xg_create_one_menuitem) > > (create_menus, xg_update_menu_item, xg_modify_menubar_widgets) > > (draw_page, xg_print_frames_dialog, xg_create_toolbar) > > (xg_im_context_commit, xg_widget_style_updated) > > (tb_size_cb): Adjust to use `get_glib_user_data' and` g_signal_connect_= data'. > > (xg_initialize): Remove linked list if HAVE_MPS. > > * src/gtkutil.h (glib_user_data, get_glib_user_data): New helper > > functions. > > * src/xmenu.c (menubar_selection_callback) > > (popup_selection_callback): Adjust to use `get_glib_user_data'. >=20 > Hello, >=20 > as on my system gsignal.h does not define G_CONNECT_DEFAULT but only > G_CONNECT_AFTER and G_CONNECT_SWAPPED this commit introduces the > following on my system: Thank you! Can you let me know which gtk/glib version that is? I'd like to = check the source code to make sure we can pass the right flag instead. I think we're okay just passing 0 instead. Pip