From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 7) Date: Thu, 20 May 2021 11:39:41 +0200 Message-ID: References: <87czudm7bv.fsf@mail.linkov.net> <976056e8-3d46-db27-32c2-ddf3ca32d5a7@daniel-mendler.de> <878s5090e9.fsf@mail.linkov.net> <69fd42ed-a1a0-adcb-ac8b-caad80cb0967@daniel-mendler.de> <878s4zzpvc.fsf@mail.linkov.net> <95ac7ef3-5e8c-fc58-b316-544096c82aa0@daniel-mendler.de> <87o8dus00b.fsf@mail.linkov.net> <6718c89f-88a0-b529-1676-7e89fc152f00@daniel-mendler.de> <878s4w3law.fsf@mail.linkov.net> <87sg2ymq6j.fsf@mail.linkov.net> <87r1ifpyuc.fsf@mail.linkov.net> <83eeef7nzh.fsf@gnu.org> <87eeed2l0q.fsf@mail.linkov.net> <83o8dh3ybw.fsf@gnu.org> <854d8dbc-b64c-77e1-843b-95ac19e230e2@daniel-mendler.de> <83h7j93wjg.fsf@gnu.org> <83a6p13uux.fsf@gnu.org> <83fsyq2ab4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6011"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gregory@heytings.org, emacs-devel@gnu.org, monnier@iro.umontreal.ca, dgutov@yandex.ru To: Eli Zaretskii , juri@linkov.net Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 20 11:40:53 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ljfAj-0001Na-DB for ged-emacs-devel@m.gmane-mx.org; Thu, 20 May 2021 11:40:53 +0200 Original-Received: from localhost ([::1]:48154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljfAi-00050w-CN for ged-emacs-devel@m.gmane-mx.org; Thu, 20 May 2021 05:40:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljf9h-0004Ic-BN for emacs-devel@gnu.org; Thu, 20 May 2021 05:39:49 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:45437 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljf9e-000869-TJ; Thu, 20 May 2021 05:39:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:References:Cc:To:From:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8/4RAcNUTlNLc4vAHJCEbk5BTGPY55Kt0PGh6Ofv2oY=; b=IpTTDitICvwNAeM07iFLfA0d2s QdTv4IXUmxhUBy2JZ0yERYHO2FvvGgqbtiJJQsq3E5EY3Xek2bts6WRl4HCuGc3mmwD0XPZLHo2dN /zHxOT73pslx6NmePXSbh0544oStUHr6owSOAQ9olsTDuJskgjUUSpsVo5zxSre7l2R8=; In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269491 Archived-At: On 5/13/21 1:45 PM, Daniel Mendler wrote: > On 5/13/21 12:32 PM, Eli Zaretskii wrote: >>> I attached the updated patches, the variable `completions-group-sort` >>> allows the more user friendly values nil and 'alphabetical. I hope it is >>> more acceptable in this form. >> >> Thanks, this addresses my concerns. >> >> (Please proofread the comments, doc strings, and Texinfo changes in >> the patches to make sure you leave 2 spaces between sentences, per our >> conventions to use US English.) > > Thank you, Eli. I went over the commit messages, comments, Texinfo and > doc strings and made a few corrections. The revised patches are attached. >From my side the attached patches are ready. Is there anything else that should be addressed? Juri, does the `group-function` work as desired for `ucs-char-names` in the current form? See my last mail "REVISED PATCH VERSION 7". Thank you! Daniel