From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spyros Roum Newsgroups: gmane.emacs.devel Subject: Add completion to compilation-read-command Date: Tue, 24 Dec 2024 08:53:46 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="------------AjZRBcqFO2p9NqlOe0nlo10W" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39834"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 24 09:54:04 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tQ0g0-000ACN-Mc for ged-emacs-devel@m.gmane-mx.org; Tue, 24 Dec 2024 09:54:04 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tQ0ff-00046v-8J; Tue, 24 Dec 2024 03:53:43 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQ0fe-00046j-1O for emacs-devel@gnu.org; Tue, 24 Dec 2024 03:53:42 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQ0fb-0003sB-Vh for emacs-devel@gnu.org; Tue, 24 Dec 2024 03:53:41 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 0D163240101 for ; Tue, 24 Dec 2024 09:53:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1735030417; bh=TmJtF83Koxgvz/5LUiq8Zd9GWQc+JMEnyvqgTBLsz5o=; h=Content-Type:Message-ID:Date:MIME-Version:To:From:Subject:From; b=ZA3oUb11m5WqENCWAaeGFaXeFs87o7ef2HB6Jy2o1b53q7S9kc5dRVMaDIvZiP9mO D+Z5ZZIwRXUqkTpOLsbpCLeqYzUqE4mag5O7omxEDcBZ68JPoZue30hyillW4yUcnr RCAsDuXFcuar/VyAvK6wMFmUmkid9ShJ2oht9Ufj9mDoUrGS6FBIxKW7mf+g7IIA8g Q4iD9t0VaaDhubaHC4dVLcdgW0LSRgWkR9n83TFaq11cVdW5szLRd3tcGf9TGzwmtz piqD0f1BGPdQXjFYem3I6IzZjZ35+WV00fXOKF3UaIOu7u5gBsRu3qzVb3isynP43Y gXapKD37NhcDg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YHTFX3p5dz9rxB for ; Tue, 24 Dec 2024 09:53:36 +0100 (CET) Content-Language: en-US, el, el-en Received-SPF: pass client-ip=185.67.36.66; envelope-from=spyros.roum@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326978 Archived-At: This is a multi-part message in MIME format. --------------AjZRBcqFO2p9NqlOe0nlo10W Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hello all, Recently, I started using `M-x compile` more but as I was used to my shell suggesting past commands as I type (and tools like atuin), I was missing auto-complete a lot. I managed to add this functionality by writing a simple function based on compilation-read-command that uses completing-read instead of read-shell-command. Then I used advice-add to overwrite the original compilation-read-command with mine. So far this works well, and as far as I can tell there is no good reason not to make compile auto-completing, it already has a history that you can navigate anyway. With that said, this is the first time I write here and the first time I'm trying to contribute to emacs, so I'm not sure what the best way to go from here would be. I think some decisions would need to be taken, for once I am not sure if it's acceptable to change the default and make it completing or if there should be an option for it. Looking forward to your feedback, thanks --------------AjZRBcqFO2p9NqlOe0nlo10W Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hello all,

Recently, I started using `M-x compile` more but as I was used to my shell suggesting past commands as I type (and tools like atuin), I was missing auto-complete a lot.
I managed to add this functionality by writing a simple function based on compilation-read-command that uses completing-read instead of read-shell-command.
Then I used advice-add to overwrite the original compilation-read-command with mine.

So far this works well, and as far as I can tell there is no good reason not to make compile auto-completing, it already has a history that you can navigate anyway.

With that said, this is the first time I write here and the first time I'm trying to contribute to emacs, so I'm not sure what the best way to go from here would be.
I think some decisions would need to be taken, for once I am not sure if it's acceptable to change the default and make it completing or if there should be an option for it.

Looking forward to your feedback, thanks

--------------AjZRBcqFO2p9NqlOe0nlo10W--