From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Adam Porter Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] EWW - use revert--buffer-function to reload, and allow reload in eww-list-buffer Date: Wed, 2 Oct 2024 19:20:52 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39203"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: eliz@gnu.org, emacs-devel@gnu.org, jporterbugs@gmail.com To: sebastian@sebasmonia.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Oct 03 02:21:47 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sw9bG-000A3I-VU for ged-emacs-devel@m.gmane-mx.org; Thu, 03 Oct 2024 02:21:47 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sw9ab-0005Tw-1b; Wed, 02 Oct 2024 20:21:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sw9aY-0005Te-Ft for emacs-devel@gnu.org; Wed, 02 Oct 2024 20:21:03 -0400 Original-Received: from dormouse.elm.relay.mailchannels.net ([23.83.212.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sw9aU-0000vg-0w; Wed, 02 Oct 2024 20:21:02 -0400 X-Sender-Id: dreamhost|x-authsender|adam@alphapapa.net Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 5DF439077A9; Thu, 3 Oct 2024 00:20:54 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a217.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id E264B9067CF; Thu, 3 Oct 2024 00:20:53 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1727914853; a=rsa-sha256; cv=none; b=NKeFI6uiOny5xdm0C4h4ZoSN2M0jXdkqfmRwgE8NTaG00zvAHp4pql8/u1KV/WfGVuL3vJ k+Ae+hu+vSdmolQtI93GBdge41czl54JoNZi7RxMqaADjPFB23xePL5CM6Ep5FDlo4DHoR ZK/YJ7fhKzW1rRvu60aq79S18XpfDgT2ifqJgXFfxv+a8jIq5OS+f0g0i5hUtX4kjG9Ts5 X1X0soXLJc7E3xnbuYM6vsVEG0U3CVxnPR8wK5RGK0fabCIttVLxUqUep4qhh55wT0y6b5 bpRJeT3yWy4qk86ijX2uOPG26BpTubcvXQq+a2wPczIjavqMIVceevqyxoDdiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1727914853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RqmdqGjw1jCDMnVWiUUjDKWvvSoa27VakmfmTMOVf5k=; b=ypwbJkbvdqR/gt3RwAn1aYQvtCwtFG0XHwKRrUwSbwO3UKcIaLXzOvsQNyCYzWw00hPeNl lYdAQKF7B2TT5W9xbx3KkNoeeO0s9bcMR3LtHAbP3N2t64DpJD1gnXCR8S18qKhy7GwXhf JnyAhbw02H5T8YfIWsD6IpxbmPNdKoRvZE+KGt+4YFXIuvrX00oofw/J/djM79+eNDfImM hPhto0GzYDPCd0Ybw53udDRfuhiFJ5DIeU+LBv6UVoi9X0DNaYkAYUClhYmsnbBHMHh4j7 Mou8f+x7tomhtLIN4eE0hZWxRN5YRHFah+EQrt/OJZ0H42Bp1WxsoGapLEoDUQ== ARC-Authentication-Results: i=1; rspamd-7d7d79db7c-xd9b6; auth=pass smtp.auth=dreamhost smtp.mailfrom=adam@alphapapa.net X-Sender-Id: dreamhost|x-authsender|adam@alphapapa.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|adam@alphapapa.net X-MailChannels-Auth-Id: dreamhost X-Broad-Abaft: 3dcfe43a1795e95f_1727914854154_2607385623 X-MC-Loop-Signature: 1727914854154:1270270575 X-MC-Ingress-Time: 1727914854154 Original-Received: from pdx1-sub0-mail-a217.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.117.197.124 (trex/7.0.2); Thu, 03 Oct 2024 00:20:54 +0000 Original-Received: from [10.66.128.201] (unknown [91.193.232.98]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: adam@alphapapa.net) by pdx1-sub0-mail-a217.dreamhost.com (Postfix) with ESMTPSA id 4XJsln1ryxzS0; Wed, 2 Oct 2024 17:20:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alphapapa.net; s=dreamhost; t=1727914853; bh=RqmdqGjw1jCDMnVWiUUjDKWvvSoa27VakmfmTMOVf5k=; h=Date:To:Cc:Subject:From:Content-Type:Content-Transfer-Encoding; b=JGYgf+2NvtS4zl0pfJf09zBmpWf0C0mePzXRZ1iDOl3xbRE4yb9lflTXDZppOlevi ncx+DjHwNk86Z0bvo60IvSkL87bM48hRBKbQRHJzJKyXupUofauf7DHjTe0JY0pQ8a NE58m1O/Kuij63rP2BHwKH1Q+nnLMVtRfikODx0Ah6zIL8o82W2MQ8Nkd5FhLApXUZ 3mThtUl19vXITi6XKq4Ka2j3KGsIw5niPnL44AMUoIbi+l8CUaI7fiDvVxGrFgoVC2 p8BQhSUOovpko0som9uwcA4Xea1TR6F+T1QqiiPZ76jsSxU6Yq9sm3KddNynOihyY4 C7pWbmhfYQltg== Content-Language: en-US In-Reply-To: Received-SPF: neutral client-ip=23.83.212.50; envelope-from=adam@alphapapa.net; helo=dormouse.elm.relay.mailchannels.net X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_NEUTRAL=0.779 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324257 Archived-At: Hi Sebastián, > Sebastián Monía writes: > >> Jim Porter writes: >> >>> On 9/20/2024 8:06 AM, Sebastián Monía wrote: >>>> If not, I will convert it to tabulated-list (or vtable), only >>>> disadvantage I see, is that it would change the internals of the buffer >>>> list quite a bit. I don't expect anyone to rely on them, though. >>> >>> I think a tabulated list would be fine. >> >> I included below a patch that does this >> >>> Your other earlier suggestion of splitting 'eww-list-buffers' in three >>> also makes sense to me though. Then one of the functions could be >>> 'eww-buffer-list' (which returns a list of EWW buffers), just like how >>> we have 'buffer-list' and 'list-buffers' in Emacs. >> >> I read this just now :( >> I can add it in a subsequent patch. >> >> BTW, 'eww-bookmark-mode' could also use a tabulated list. >> I use the eww specific bookmarks or some pages (and "general" bookmarks >> for others, everyone has their workflows I guess). >> >> If you all think it is worth it, I can make a similar change to this one >> for bookmarks. And add 'eww-list-buffers' too. > > Hello! > Reviving this thread before attempting the bookmark changes - just in > case there's some feedback on the tabulated list setup and usage. A list buffer for EWW bookmarks sounds useful, but I'd suggest using the newer Vtable library rather than tabulated-list. :) --Adam