From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: master fails to build on FreeBSD when ACL support is on Date: Fri, 19 Jan 2018 16:17:25 -0500 Message-ID: References: <86o9lua0yx.fsf@phe.ftfl.ca> <834lnly8ht.fsf@gnu.org> <86vafy20sj.fsf@phe.ftfl.ca> <83o9lpuct5.fsf@gnu.org> <83lggtu1qn.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1516396595 18105 195.159.176.226 (19 Jan 2018 21:16:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 19 Jan 2018 21:16:35 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 19 22:16:31 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ece1G-0003Tm-Nv for ged-emacs-devel@m.gmane.org; Fri, 19 Jan 2018 22:16:14 +0100 Original-Received: from localhost ([::1]:45796 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ece3G-0008C7-T7 for ged-emacs-devel@m.gmane.org; Fri, 19 Jan 2018 16:18:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53176) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ece2U-0008B4-9F for emacs-devel@gnu.org; Fri, 19 Jan 2018 16:17:31 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ece2T-0007cP-HQ for emacs-devel@gnu.org; Fri, 19 Jan 2018 16:17:30 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ece2Q-0007bZ-Ni; Fri, 19 Jan 2018 16:17:26 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ece2P-0004er-Va; Fri, 19 Jan 2018 16:17:26 -0500 X-Spook: Human to Human Tamil Tigers Perl-RSA Vickie Weaver X-Ran: oK(O-{:~~>-q(xPRoG,aRYp)40Zj=,@"[|:B@)-!:E,U{p]+^@Vu90V.m.l#+sK45%HMw) X-Hue: yellow X-Attribution: GM In-Reply-To: (Stefan Monnier's message of "Fri, 19 Jan 2018 15:53:33 -0500") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222098 Archived-At: Stefan Monnier wrote: > Looking at the history of the code, the temp-file code started with > > (make-temp-file target-file) > > which seems to me to be the result of an oversight: the original coder > probably didn't realize that such a call would either create the temp > file in the same directory as target-file or under /tmp depending on > whether target-file is relative or absolute. > > Furthermore, later the code does `rename-file` which is an operation > which works much better when the old name and new new are both in the > same partition. So I think the intention of the code was to always put > the tempfile next to the target-file. You're absolutely right. It was intentional in 0f34ae2 that the tempfile be on the same filesystem as the target file, for the usual reasons. I had actually been meaning to mention that 785a4a1 changed that, but never got round to it.