From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: [PATCH] * etc/themes/wombat-theme.el: Don't set foreground on region Date: Mon, 14 Mar 2016 10:31:47 -0700 (PDT) Message-ID: References: <1456189471-18273-1-git-send-email-mitch.special@gmail.com> <87egbxid4e.fsf@gmail.com> <87poux9dpm.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1457976737 610 80.91.229.3 (14 Mar 2016 17:32:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 14 Mar 2016 17:32:17 +0000 (UTC) Cc: Kristoffer Gronlund , emacs-devel@gnu.org To: Mitchel Humpherys Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 14 18:32:03 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1afWLa-0002kB-6s for ged-emacs-devel@m.gmane.org; Mon, 14 Mar 2016 18:32:02 +0100 Original-Received: from localhost ([::1]:42731 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afWLZ-0008WP-JZ for ged-emacs-devel@m.gmane.org; Mon, 14 Mar 2016 13:32:01 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51937) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afWLW-0008W5-2j for emacs-devel@gnu.org; Mon, 14 Mar 2016 13:31:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afWLR-0006uf-WF for emacs-devel@gnu.org; Mon, 14 Mar 2016 13:31:57 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:23360) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afWLR-0006uQ-PR for emacs-devel@gnu.org; Mon, 14 Mar 2016 13:31:53 -0400 Original-Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u2EHVnV1027203 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 14 Mar 2016 17:31:49 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u2EHVnMI001460 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Mon, 14 Mar 2016 17:31:49 GMT Original-Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u2EHVmOi009712; Mon, 14 Mar 2016 17:31:49 GMT In-Reply-To: <87poux9dpm.fsf@gmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 141.146.126.69 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:201721 Archived-At: > >> > Setting a foreground color on the `region' face is slightly > >> > annoying. > >> > This is subjective, of course, but the consensus among other > >> > themes and around the web is to *not* set a foreground color > >> > on the region face. > >> > >> Any objections to this? I should have mentioned that the reason > >> it's slightly annoying is because setting a foreground color hides > >> existing syntax highlighting within the region text. > > > > A particular theme can do anything its authors and users want, > > of course. But wrt the general question of whether region (aka > > selection) highlighting should override other highlighting, see > > Emacs bug #15899. > > > > http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D15899 > > > > IMO, selection highlighting should, at least by default, visibly > > cover the entire selection. Otherwise, it is not always clear > > what the region limits are. >=20 > Just to be clear, when I said "syntax highlighting" I meant it in the > general sense of colors applied to the *foreground* of code in order to > highlight the syntax of the language. I believe you're referring to > background highlighting, which shouldn't be affected by this patch. I too was speaking of foreground highlighting (as well as background highlighting). I was speaking directly to your point about "setting a foreground color hides existing syntax highlighting within the region text." Please see the referenced bug thread, if you are interested in the question. It is about whether, when, and why region highlighting (foreground, background, or both) should hide other highlighting.