From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: marginalia Date: Tue, 1 Jun 2021 23:07:39 +0200 Message-ID: References: <5146817f-4b3f-8a7e-edce-f34a9a10f805@daniel-mendler.de> <871r9qk9el.fsf@mail.linkov.net> <92c218f7-1168-a7f4-3861-04f64a37eec9@daniel-mendler.de> <874kehcnl6.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33044"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?UTF-8?Q?Omar_Antol=c3=adn_Camarena?= , Stefan Monnier , "emacs-devel@gnu.org" To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 01 23:08:45 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loBcx-0008Lf-Sx for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Jun 2021 23:08:43 +0200 Original-Received: from localhost ([::1]:36390 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loBcw-0001h1-IC for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Jun 2021 17:08:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54138) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loBc4-00010s-T1 for emacs-devel@gnu.org; Tue, 01 Jun 2021 17:07:51 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:43379 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loBc0-0003by-BM for emacs-devel@gnu.org; Tue, 01 Jun 2021 17:07:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YnVJR4iTK+O/HZxwqzr3cQRVu+YNkgK8JLnY+p4JhrM=; b=Equkx7MDK2WYq3BfNbnm3IpNPP +KL7YJSkkhxcnmqYuaUe4nxcpjy0q92Y6n75Y9lC3ijgh8XpwFEtyUd+XMQoi7F/dYbrSr4dIdlSE 9Om5VCSY15QEQXS53r3VnJeS+WG5Tv693zID4HDh7C3qSYOS8N63Del2bZbPrz0Q3rkg=; In-Reply-To: <874kehcnl6.fsf@mail.linkov.net> Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270252 Archived-At: On 6/1/21 10:54 PM, Juri Linkov wrote: >>>> BTW, I hope we can merge some of that code directly into Emacs itself. >>> >>> For example, marginalia--symbol-class adds new symbol characters to >>> the replacement of `help--symbol-completion-table-affixation', >>> but it would be better to add new characters directly to >>> `help--symbol-completion-table-affixation'... >> >> Yes, I would be glad if you merge back the `marginalia--symbol-class` to >> the Emacs help system! The `marginalia--symbol-class` has been inspired >> by your `help--symbol-completion-table-affixation`, but I wanted to go a >> little step further in Marginalia. Maybe it makes sense to add >> `help--symbol-class` such that the function can be reused potentially at >> other places? > > Maybe something like... > Then you could use it, and prepend/append more characters > such as: o for obsolete, ! for advised, * for modified. I am not sure if we would benefit much from this in Marginalia, since we would still have to check the type of the symbol. What about adding the extended `symbol-class` function from Marginalia directly to help-fns.el? Note that the Marginalia function returns multiple characters "fv" if a symbol denotes both a function and a variable. Do you want to keep the `symbol-class` to be a single character under all circumstances? Daniel ~~~ (defun marginalia--symbol-class (s) "Return symbol class characters for symbol S. Function: f function c command m macro ! advised o obsolete Variable: u custom v variable l local * modified o obsolete Other: a face t cl-type" (format "%-6s" (concat (when (fboundp s) (concat (and (get s 'byte-obsolete-info) "o") (cond ((commandp s) "c") ((eq (car-safe (symbol-function s)) 'macro) "m") (t "f")) (and (marginalia--advised s) "!"))) (when (boundp s) (concat (and (get s 'byte-obsolete-variable) "o") (and (local-variable-if-set-p s) "l") (if (custom-variable-p s) "u" "v") (and (ignore-errors (not (equal (symbol-value s) (default-value s)))) "*"))) (and (facep s) "a") (and (fboundp 'cl-find-class) (cl-find-class s) "t")))) ~~~