unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Aaron Conole <aconole@bytheb.org>
To: emacs-devel@gnu.org
Subject: [PATCH] Call va_end after processing ap
Date: Mon, 02 May 2016 15:39:26 -0400	[thread overview]
Message-ID: <f7tzis8medr.fsf@redhat.com> (raw)

* gnutls.c (boot_error): A recent change added a function to signal an
error or return an error code. That function uses a variadic argument
list to populate an error message string. However, it missed calling
va_end after using the variadic argument list.

---
NOTE: I sent a copy of this from my work email (which isn't
subscribed). Sorry if it is duplicated in the email system, but I didn't
see it land so I'm resending.

 src/gnutls.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/gnutls.c b/src/gnutls.c
index 57b164a..1089b1a 100644
--- a/src/gnutls.c
+++ b/src/gnutls.c
@@ -1181,6 +1181,7 @@ boot_error (struct Lisp_Process *p, const char *m, ...)
     pset_status (p, list2 (Qfailed, vformat_string (m, ap)));
   else
     verror (m, ap);
+  va_end(ap);
 }
 
 Lisp_Object
-- 
2.5.5



             reply	other threads:[~2016-05-02 19:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-02 19:39 Aaron Conole [this message]
2016-05-02 20:04 ` [PATCH] Call va_end after processing ap Eli Zaretskii
  -- strict thread matches above, loose matches on Subject: below --
2016-05-02 19:39 Aaron Conole
2016-05-02 21:42 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7tzis8medr.fsf@redhat.com \
    --to=aconole@bytheb.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).