From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: Question about dubious code for terminal frames Date: Mon, 2 Sep 2024 19:32:11 +0200 Message-ID: References: <86wmju8em4.fsf@gnu.org> <86ed628aa3.fsf@gnu.org> <868qwa86nq.fsf@gnu.org> <867cbu842s.fsf@gnu.org> <7f6a1078-6780-43df-9ca5-ed500c7434a1@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="889"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: Eli Zaretskii , emacs-devel@gnu.org To: =?UTF-8?Q?Gerd_M=C3=B6llmann?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 02 19:33:15 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1slAvT-000AYV-0Y for ged-emacs-devel@m.gmane-mx.org; Mon, 02 Sep 2024 19:33:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1slAuc-00077k-GO; Mon, 02 Sep 2024 13:32:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slAua-00077U-Ls for emacs-devel@gnu.org; Mon, 02 Sep 2024 13:32:20 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slAuX-00086w-Mf; Mon, 02 Sep 2024 13:32:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1725298333; x=1725903133; i=rudalics@gmx.at; bh=V+oz+rFt7Pq2goufSInMxQF+ZXlbAkajugIybE4dRy4=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=jPtoBpF+Gsvi3zEuh0fApNoy88lTyEOhMmmF5D7phWW8O/RRHwj34V07yG6Kn7nn wjrVOyvtiChwC5hIT/18XgF1+dTuXhmgFmRcDCaPu+7SU+iMSHgWZtGHpU4iN1rQF 2wy/EeBekaoLzBB1mIS43USJjIV49IHG5Ft/pY0X9ansHsF32iWMIT9O6R2JFSHt/ 8Uhb4GXEwMoTAI8Wep+QvC+SThnQfoExyCtb2E7xqvlxXVckeSk43jTvZnCB7J4rC h6xE9cTWPQBl4eWbAs1vlFYfjP7DIpFNI5eXyFT2eeprWGyv0+SE8L0DWtNz9Ai+v FbuEdJlRX4zwmqcdFA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from [192.168.31.113] ([212.95.5.153]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MxlzC-1rrPHv1f9K-00wY11; Mon, 02 Sep 2024 19:32:13 +0200 Content-Language: en-US In-Reply-To: X-Provags-ID: V03:K1:Vu7X2IWjzs0jQ4jvgpqSe8UB26cd9QBnK1zGkteRsdYaV0OymU4 t1sOBcm86D0gefb4bRpFXza2luVhQ6QUDExc7mS9cZFMBddjMNlaIsc0AQDQdeHkeuZlqRZ KP1OmQmO2H4xqiDjqWSnL1+9ruxJomuzsE+XBULVYIvBpGGXhIvOF+DSwgJplT5g1tBQlJw jkOrfXM0GvxDaoczRjiSQ== UI-OutboundReport: notjunk:1;M01:P0:lQHMsr7iGkw=;opYUrVr0g1+3+2EEHWiEoo9otcM H1ll60jUZ/LDEK/xKv+i86LDXLqW43J4uA9YYk+0apNW4y4V+lstjhJY4k94XBUom0Q2qoQG7 bowmVZ3KTMQq8hGuTzJozN9aUpEHJogoYRJnspMK97T5gQS2D/fScANEMVH8+7kZ2iFVvPd05 /rAwKYqU0RuObs0bb76vmfFCjw4TfK9ZiMsQzdqjld/sLzgTLa6pP74M/ZEfK1f8QXD20IfZX 9wMR/sLkazgn85Wf2FX2dszIYWhM8T/Vva/il+qdE8Lpt5E13yYUXNCMHk0iBeA7jP/9IcGCu YJuwUsyYrWO8Kky5bBbaBFFtn2hAM5jZNgkdeu9RyemYyFUP19fsPE5hcGeK0BYP3h3rphkoL neKBCufI+d4+EaS2Ku1S7sLHC5mUQ7UByIYTYUQTKRg3h7jRuKUilEe0GSoh7c4bsv5KnkHJw 2ni5QCm8muVtJrGaSRMc3lAY8phaja/jkYsiA53R7IMx57kh+Vb18QTVwbjTFhohmWGMFz/IF uRznOZ70Xj2cJtHhF5CE5y7YXU1KYKRp71yf6vfFabLEEZ0pKE73YDsLBslNCeOIHU8XzEDUP iBYvqP5U0f21oyvlfsslIAjsiaDv8SqCmkoYph6mXF8cmvs4Ge/51dk7jr9uws+pUaDOTnKRE UI7Mo8CT2OH+z7EkgJ/IBnsKW3ZjcYqmfaCSzAdgTygTmp5+yn+gRzpdbmjGq4sfpn9WjvI4M Ny+zJnAM1naOuuGAyKtLW2mqRAJzFIHOMQWgS+AhVCPFdKxp+N8qyxxzBdnzsI0OubT2b04x Received-SPF: pass client-ip=212.227.17.22; envelope-from=rudalics@gmx.at; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323305 Archived-At: > I think I have the above here. It reads > > /* Assign new sizes. */ > FRAME_COLS (f) = new_text_cols; > FRAME_LINES (f) = new_text_lines; It might cause something weird in resize_frame_windows, but that's maybe only here. > Anyway. My problem is setting FrameCols/Rows in adjust_frame_size. It's > not guaranteed that the terminal's size has indeed changed when that is > done. You mean the FrameRows (FRAME_TTY (f)) = FrameCols (FRAME_TTY (f)) = assignments? These are from the pre-2014 change_frame_size_1 code with the comments mostly preserved and governed by similar conditions. Do you think something changed here? But I agree that for child frames with their own smaller dimensions these assignments should be obviously skipped. martin