unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: "Gerd Möllmann" <gerd.moellmann@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: Question about dubious code for terminal frames
Date: Mon, 2 Sep 2024 19:32:11 +0200	[thread overview]
Message-ID: <f7da7bcf-4b6b-4041-b915-034d604d8463@gmx.at> (raw)
In-Reply-To: <m2plpm6mps.fsf@pro2.fritz.box>

 > I think I have the above here. It reads
 >
 >    /* Assign new sizes.  */
 >    FRAME_COLS (f) = new_text_cols;
 >    FRAME_LINES (f) = new_text_lines;

It might cause something weird in resize_frame_windows, but that's maybe
only here.

 > Anyway. My problem is setting FrameCols/Rows in adjust_frame_size. It's
 > not guaranteed that the terminal's size has indeed changed when that is
 > done.

You mean the

	FrameRows (FRAME_TTY (f)) =
	FrameCols (FRAME_TTY (f)) =

assignments?  These are from the pre-2014 change_frame_size_1 code with
the comments mostly preserved and governed by similar conditions.  Do
you think something changed here?

But I agree that for child frames with their own smaller dimensions
these assignments should be obviously skipped.

martin



  reply	other threads:[~2024-09-02 17:32 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-02  9:04 Question about dubious code for terminal frames Gerd Möllmann
2024-09-02  9:10 ` Andreas Schwab
2024-09-02  9:48   ` Gerd Möllmann
2024-09-02 10:23     ` Andreas Schwab
2024-09-02 10:46       ` Gerd Möllmann
2024-09-02 11:44 ` Eli Zaretskii
2024-09-02 12:59   ` Gerd Möllmann
2024-09-02 13:17     ` Eli Zaretskii
2024-09-02 14:11       ` Gerd Möllmann
2024-09-02 14:35         ` Eli Zaretskii
2024-09-02 14:54           ` Gerd Möllmann
2024-09-02 15:31             ` Eli Zaretskii
2024-09-02 15:46               ` Gerd Möllmann
2024-09-02 15:55                 ` Eli Zaretskii
2024-09-02 16:24                   ` Gerd Möllmann
2024-09-02 16:35                     ` Eli Zaretskii
2024-09-02 16:38                       ` Gerd Möllmann
2024-09-02 17:39                         ` Eli Zaretskii
2024-09-02 16:20               ` martin rudalics
2024-09-02 16:31                 ` Gerd Möllmann
2024-09-02 17:32                   ` martin rudalics [this message]
2024-09-02 18:02                     ` Gerd Möllmann
2024-09-02 18:26                       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7da7bcf-4b6b-4041-b915-034d604d8463@gmx.at \
    --to=rudalics@gmx.at \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=gerd.moellmann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).