unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juanma Barranquero <lekktu@gmail.com>
To: ams@gnu.org
Cc: "Óscar Fuentes" <ofv@wanadoo.es>, emacs-devel@gnu.org
Subject: Re: Commit netiquette.
Date: Thu, 18 Feb 2010 16:12:47 +0100	[thread overview]
Message-ID: <f7ccd24b1002180712s704c99faq88e8a7ce7c8e16b3@mail.gmail.com> (raw)
In-Reply-To: <E1Ni7dY-0005p4-Ew@fencepost.gnu.org>

On Thu, Feb 18, 2010 at 15:45, Alfred M. Szmidt <ams@gnu.org> wrote:

> This seems more of a short comming in `bzr log --short' than in the
> way one writes commit messages.  A commit message is more than a
> single line.  And the purpose of a change is always more suitable in
> the actual code as a comment.

You're conflating quite different things. If I update my tree with
"bzr up", obviously I'm not going to go looking at the code to know
which changes were made, but I certainly will do "bzr log --line -l10"
to see recent changes and their purpose.

And it is ridiculous to say that it is a "shortcoming" of log --short.
--short or --line are a convenience; making sure that the first line
of the commit log summarizes the change is just being nice to fellow
developers. You can always see the full log if you want; is not like
following the recommendation somehow impedes you from writing as long
a commit message as you want.

We currently *have* policies about ChangeLog entries and commit logs,
so I agree with Óscar: it is a good practice and we should require
people to follow it; and treat people who doesn't the same way we
treat people who mangles ChangeLog entries (that is, a gentle but firm
reminder that we have guideliness and we're all expected to follow
them).

    Juanma




  reply	other threads:[~2010-02-18 15:12 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-17 23:44 Commit netiquette Óscar Fuentes
2010-02-18  0:27 ` Glenn Morris
2010-02-18  0:51   ` Óscar Fuentes
2010-02-18  5:35     ` Glenn Morris
2010-02-18  7:13       ` Chong Yidong
2010-02-18 15:11         ` Mark A. Hershberger
2010-02-18 14:45 ` Alfred M. Szmidt
2010-02-18 15:12   ` Juanma Barranquero [this message]
2010-02-18 16:14     ` Stefan Monnier
2010-02-19  3:42       ` David Reitter
2010-02-19  5:32         ` Stefan Monnier
2010-02-19  8:17       ` Alfred M. Szmidt
2010-02-19 18:19         ` Stefan Monnier
2010-02-20 11:02           ` Chong Yidong
2010-02-20 11:06         ` Chong Yidong
2010-02-23 19:25           ` Alfred M. Szmidt
2010-02-19  8:17     ` Alfred M. Szmidt
2010-02-19  8:39       ` Juanma Barranquero
2010-02-20 12:37         ` Alfred M. Szmidt
2010-02-20 14:13           ` Miles Bader
2010-02-20 14:23             ` Eli Zaretskii
2010-02-22  2:17               ` Miles Bader
2010-02-22  4:14                 ` Eli Zaretskii
2010-02-23 16:37                   ` Stefan Monnier
2010-02-23 19:25               ` Alfred M. Szmidt
2010-02-20 18:55           ` Juanma Barranquero
2010-02-23 19:25             ` Alfred M. Szmidt
2010-02-23 20:28               ` Juanma Barranquero
2010-02-23 22:09                 ` David Kastrup
2010-02-23 22:57                   ` Juanma Barranquero
2010-02-18 15:40   ` Óscar Fuentes
2010-02-19  0:22     ` Stephen J. Turnbull
2010-02-19  7:53   ` Miles Bader
2010-02-18 15:15 ` Mark A. Hershberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7ccd24b1002180712s704c99faq88e8a7ce7c8e16b3@mail.gmail.com \
    --to=lekktu@gmail.com \
    --cc=ams@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=ofv@wanadoo.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).