font italic displaying on windows

font italic displaying on windows

[Toru TSUNEYOSHI]

[-- Attachment #1: Type: Text/Plain, Size: 344 bytes --]

Hello.

Emacs 23.1.1 on Windows don't display slant italic in some fonts, such
as Japanese "MS Gothic", "MS Mincho", and various fonts.

I wished that Emacs can display slant italic in those fonts, so I made a
very, very, easy patch.
(Maybe it is incomplete and problematic, I think. But it's useful.)

Could someone seek the better solution ?

[-- Attachment #2: w32font.c.diff --]
[-- Type: Text/X-Patch, Size: 1127 bytes --]

--- w32font.c.orig	Sat Apr 25 15:11:47 2009
+++ w32font.c	Tue Oct 20 17:45:21 2009
@@ -1131,6 +1131,8 @@
 #define CSB_KOREAN ((1 << 19) | (1 << 21))
 #define CSB_CHINESE ((1 << 18) | (1 << 20))
 
+extern int w32_enable_synthesized_fonts;
+
 static int
 font_matches_spec (type, font, spec, backend, logfont)
      DWORD type;
@@ -1143,6 +1145,7 @@
 
   /* Check italic. Can't check logfonts, since it is a boolean field,
      so there is no difference between "non-italic" and "don't care".  */
+  if (!w32_enable_synthesized_fonts)
   {
     int slant = FONT_SLANT_NUMERIC (spec);
 
@@ -1448,6 +1451,8 @@
 			    logical_font->elfFullName)))
     return 1;
 
+  do
+    {
   /* Make a font entity for the font.  */
   entity = w32_enumfont_pattern_entity (match_data->frame, logical_font,
 					physical_font, font_type,
@@ -1504,6 +1509,11 @@
       /* Add this font to the list.  */
       match_data->list = Fcons (entity, match_data->list);
     }
+    }
+  while (w32_enable_synthesized_fonts
+	 && logical_font->elfLogFont.lfItalic == FALSE
+	 ? (logical_font->elfLogFont.lfItalic = TRUE, 1)
+	 : 0);
   return 1;
 }
 

Re: font italic displaying on windows

[Jason Rumney]

Toru TSUNEYOSHI wrote:

	+extern int w32_enable_synthesized_fonts;

The whole definition and initialization of this variable should be moved to w32font.c, as it is not used elsewhere.

Re: font italic displaying on windows

[Toru TSUNEYOSHI]

> Toru TSUNEYOSHI wrote:
> 
> 	+extern int w32_enable_synthesized_fonts;
> 
> The whole definition and initialization of this variable should be moved
> to w32font.c, as it is not used elsewhere.

I also think so.
(If it is suitable, I wish someone deals with it.)

Re: font italic displaying on windows

[Juanma Barranquero]

On Wed, Oct 21, 2009 at 02:27, Jason Rumney <jasonr@gnu.org> wrote:
> Toru TSUNEYOSHI wrote:
>
>        +extern int w32_enable_synthesized_fonts;
>
> The whole definition and initialization of this variable should be moved to
> w32font.c, as it is not used elsewhere.

Unless Tsuneyoshi-san's patch (or similar) is accepted,
w32_enable_synthesized_fonts is in fact not used anywhere...

    Juanma