Re: [Emacs-diffs] emacs/lisp image.el

[Juanma Barranquero <lekktu@gmail.com>]

On Sun, Aug 30, 2009 at 00:46, Juri Linkov<juri@jurta.org> wrote:

> I left `image-jpeg-p' in image.el for the case it's used by some
> external packages or .emacs files since it contains a non-trivial
> algorithm for detecting JFIF/Exif JPEGs.  Even though its name is
> not too specific, its docstring explains what it does.

IMO, it is inconsistent with what image.el (or indeed Emacs) offers;
we don't have functions to detect the different image formats
supported by TIFF, for example.

`image-jpeg-p' was never a published interface, just a helper
function. As a very crude test, googling for it brings a few hits
(plus "image/jpeg" false hits), most of which seem to be from our code
or bug reports. It's unlikely the function has received wide usage
(yes, private libraries and most .emacs files do not appear in Google;
I said "crude").

If removing it is too severe, at least obsoleting it seems to be in
order. It is unused in the sources, too specific, inconsistently
documented, and internal.

    Juanma