From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Juanma Barranquero" Newsgroups: gmane.emacs.devel Subject: Re: Optimized gcc 4.3.0 build on Windows returns 0 secs for all time values of system-process-attributes Date: Sat, 3 Jan 2009 18:14:05 +0100 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1231003013 16120 80.91.229.12 (3 Jan 2009 17:16:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 3 Jan 2009 17:16:53 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Eli Zaretskii" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 03 18:18:02 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LJA8F-000355-MD for ged-emacs-devel@m.gmane.org; Sat, 03 Jan 2009 18:17:56 +0100 Original-Received: from localhost ([127.0.0.1]:35443 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LJA6y-0004WW-TF for ged-emacs-devel@m.gmane.org; Sat, 03 Jan 2009 12:16:32 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LJA4h-00049B-01 for emacs-devel@gnu.org; Sat, 03 Jan 2009 12:14:11 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LJA4f-00048X-FA for emacs-devel@gnu.org; Sat, 03 Jan 2009 12:14:10 -0500 Original-Received: from [199.232.76.173] (port=45563 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LJA4f-00048Q-AK for emacs-devel@gnu.org; Sat, 03 Jan 2009 12:14:09 -0500 Original-Received: from yx-out-1718.google.com ([74.125.44.156]:53570) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LJA4d-0004Xk-Dg; Sat, 03 Jan 2009 12:14:07 -0500 Original-Received: by yx-out-1718.google.com with SMTP id 34so2222742yxf.66 for ; Sat, 03 Jan 2009 09:14:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=KmaiUgEEwYND8ZOOs4AwwOkH/YpoGhk8vDXEUdNU+LY=; b=XLUsvTMJ+3c5DJIa4Qkvh4EaIvJcjg7RFvO6juE+0/Zs2eAZ1TBSWxYYpneD6Raf/C lyWPBm4jyWMPVuHj6JwyTi6pdROLzs8MpboI4jc7vUsauwwT0q3K8ly6r5Y1bxaPV92R sNFjmuY3UwMRCVU2Zxy1nzKI0MDm/DFlqyIEQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=sp/i2xtYu6/qzMPaNOQwdSCA9nWjhrtdn2dRR72/SFToXMxDTa9Wvom37nZIXDNG2r LLLiTcvJo6T7WWKebEDkICOWVPLc21NsExu6Hbl1vqwTXPZWygqPZ0bN3d3WCRgFU9on ZVUeuydLosKjMMEJXU/WBtp8I0LwMHsFhbgrI= Original-Received: by 10.100.43.10 with SMTP id q10mr10334213anq.1.1231002845201; Sat, 03 Jan 2009 09:14:05 -0800 (PST) Original-Received: by 10.100.13.13 with HTTP; Sat, 3 Jan 2009 09:14:05 -0800 (PST) In-Reply-To: Content-Disposition: inline X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:107553 Archived-At: On Sat, Jan 3, 2009 at 17:56, Eli Zaretskii wrote: > It's probably worth reporting that to the GCC mailing list, and/or > file a bug report with them. Yes, will do. > Please install your change, but please try making the code more > concise and clear, if possible. For example, you could introduce a > macro or an inline function for this repeated pattern: > >> + tem1.LowPart = ft_kernel.dwLowDateTime; >> + tem1.HighPart = ft_kernel.dwHighDateTime; >> + tem1.QuadPart /= 10L; The patch I was using locally already has two macros: #define CONVERT_TO_ULARGE(result, ft, div) \ do { \ (result).LowPart = (ft).dwLowDateTime; \ (result).HighPart = (ft).dwHighDateTime; \ if (div) \ (result).QuadPart /= (div); \ } while (0) #define TO_LISP_OBJECT(time) ltime ((time).QuadPart / 1000000L, (time).QuadPart % 1000000L) so most conversions are like this: CONVERT_TO_ULARGE (tem1, ft_kernel, 10L); *stime = TO_LISP_OBJECT (tem1); (better names are very welcome). > In addition, please also change the other user of convert_time_raw > similarly to this. Yes, of course. Juanma