From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Juanma Barranquero" Newsgroups: gmane.emacs.devel Subject: Re: bug in server-start Date: Tue, 16 Dec 2008 13:15:54 +0100 Message-ID: References: <18758.7352.558182.931572@kahikatea.snap.net.nz> <18758.14760.572830.277734@kahikatea.snap.net.nz> <200812151724.mBFHOSnS029425@mothra.ics.uci.edu> <18759.21210.387155.565065@a1ihome1.kph.uni-mainz.de> <18759.38348.81160.828820@a1i15.kph.uni-mainz.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1229429777 19428 80.91.229.12 (16 Dec 2008 12:16:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 16 Dec 2008 12:16:17 +0000 (UTC) Cc: Nick Roberts , Dan Nicolaescu , Stefan Monnier , emacs-devel@gnu.org To: "Ulrich Mueller" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 16 13:17:22 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LCYrY-0000Cd-1f for ged-emacs-devel@m.gmane.org; Tue, 16 Dec 2008 13:17:21 +0100 Original-Received: from localhost ([127.0.0.1]:35957 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LCYqJ-0005Yf-9v for ged-emacs-devel@m.gmane.org; Tue, 16 Dec 2008 07:16:03 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LCYqD-0005XB-J2 for emacs-devel@gnu.org; Tue, 16 Dec 2008 07:15:57 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LCYqC-0005Vn-3f for emacs-devel@gnu.org; Tue, 16 Dec 2008 07:15:57 -0500 Original-Received: from [199.232.76.173] (port=42633 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LCYqB-0005Vc-R4 for emacs-devel@gnu.org; Tue, 16 Dec 2008 07:15:55 -0500 Original-Received: from mail-gx0-f14.google.com ([209.85.217.14]:43873) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LCYqB-0006Sd-H7 for emacs-devel@gnu.org; Tue, 16 Dec 2008 07:15:55 -0500 Original-Received: by gxk7 with SMTP id 7so2441167gxk.18 for ; Tue, 16 Dec 2008 04:15:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=1+zP1DSI//T+7kg57USTM6eFkt6lENpZU0Ajyk+SwTQ=; b=dxgMc13X4cpPDg6+6M4AtYx7UJk/JCnbTC6kmR+KBQvh/vMfP9LPdzb+wjyoYxolDC GqUHAsC6fSbiXeL66rpmJfd/0E2kfEHEKubweyPsF9D2PymhSfAxBusZAEq7QEiQ0vKq 4onRaIz9UnOneNLHUEHvqA44xp7NBCplDpr38= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=ZWoK47g4RQv6L239pLZQI566mb697QaWhk/J5xw7VZZgNmcTZ8FGf7ffVmYxTrnu1F W2tJLDkH9Rk84GOstWVcN8WtE4I11S3wQ+t8dx3cC9ftcBt7jehWMJWBWwFKXzeuvXTy fIHfoyeft/wh3LsEaYNgP4a30G3ZbVBClQyB8= Original-Received: by 10.100.122.12 with SMTP id u12mr5398675anc.78.1229429754812; Tue, 16 Dec 2008 04:15:54 -0800 (PST) Original-Received: by 10.100.13.13 with HTTP; Tue, 16 Dec 2008 04:15:54 -0800 (PST) In-Reply-To: <18759.38348.81160.828820@a1i15.kph.uni-mainz.de> Content-Disposition: inline X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:106960 Archived-At: On Tue, Dec 16, 2008 at 12:49, Ulrich Mueller wrote: > Looks good, except for the exit status of the parent which is zero. > The following will test for one character to be read from the pipe > (which is sent when daemon-initialized is called): > > --- src/emacs.c > +++ src/emacs.c > @@ -1124,7 +1124,7 @@ > } > while (retval == -1 && errno == EINTR); > > - if (retval < 0) > + if (retval <= 0) > { > fprintf (stderr, "Error reading status from child\n"); > exit (1); > I cannot test that part of the code, so I'll leave that change for Dan. As for my changes, have you tested them? ("Looks good" is not the same as "Works OK" ;-) Juanma