From: "Juanma Barranquero" <lekktu@gmail.com>
To: "Kenichi Handa" <handa@m17n.org>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: size of emacs executable after unicode merge
Date: Fri, 28 Nov 2008 17:11:31 +0100 [thread overview]
Message-ID: <f7ccd24b0811280811k5996b24dla2a1692af64da2c9@mail.gmail.com> (raw)
In-Reply-To: <E1L5euz-0005r3-IQ@etlken.m17n.org>
On Thu, Nov 27, 2008 at 12:20, Kenichi Handa <handa@m17n.org> wrote:
> After taking over Chong's experiment, I could reduce the
> size of Emacs executables about 7M bytes. About 4M bytes
> were actually because of charset mapping tables, and it
> could be reduced by setting up C structure temp_charset_work
Your big patch of 2008-11-27 has caused a change when decoding some
filenames. I've detected it because I have a fix for bug#1433 that
works before your changes, but does not work afterwards.
I'm testing by adding the following line to Fw32_short_file_name:
filename = ENCODE_FILE (filename);
before the call to GetShortPathName.
Before your changes,
1783 filename = ENCODE_FILE (filename);
(gdb) p filename
$5 = 52759907
(gdb) xstring
$6 = (struct Lisp_String *) 0x3250d60
"c:/acci\303\263n/"
(gdb) next
1786 if (GetShortPathName (SDATA (filename), shortname, MAX_PATH) == 0)
(gdb) p filename
$7 = 52759971
(gdb) xstring
$8 = (struct Lisp_String *) 0x3250da0
"c:/acci\363n/"
After your changes,
1783 filename = ENCODE_FILE (filename);
(gdb) p filename
$5 = 55776275
(gdb) xstring
$6 = (struct Lisp_String *) 0x3531410
"c:/acci\303\263n/"
(gdb) next
1786 if (GetShortPathName (SDATA (filename), shortname, MAX_PATH) == 0)
(gdb) p filename
$7 = 55776339
(gdb) xstring
$8 = (struct Lisp_String *) 0x3531450
"c:/acci n/"
Juanma
next prev parent reply other threads:[~2008-11-28 16:11 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 3:13 size of emacs executable after unicode merge Evil Boris
2008-05-14 3:51 ` Dan Nicolaescu
2008-05-14 16:39 ` Richard M Stallman
2008-05-14 16:52 ` Dan Nicolaescu
2008-05-15 14:18 ` Richard M Stallman
2008-05-15 15:29 ` Dan Nicolaescu
2008-05-16 11:31 ` Richard M Stallman
2008-05-16 12:06 ` Dan Nicolaescu
2008-05-16 12:32 ` Kenichi Handa
2008-05-16 12:55 ` Jason Rumney
2008-05-16 15:59 ` Thomas Lord
2008-05-16 22:07 ` Stephen J. Turnbull
2008-05-16 23:01 ` Thomas Lord
2008-05-17 0:56 ` Kenichi Handa
2008-05-17 1:52 ` YAMAMOTO Mitsuharu
2008-05-19 1:45 ` Kenichi Handa
2008-10-30 10:18 ` Emanuele Giaquinta
2008-10-30 21:22 ` Eli Zaretskii
2008-10-30 21:42 ` Stefan Monnier
2008-10-31 3:55 ` Richard M. Stallman
2008-10-31 5:29 ` Kenichi Handa
2008-10-31 6:32 ` Chong Yidong
2008-10-31 7:32 ` Kenichi Handa
2008-10-31 10:09 ` Eli Zaretskii
2008-10-31 12:33 ` gdb error [Re: size of emacs executable after unicode merge] Kenichi Handa
2008-10-31 14:28 ` Eli Zaretskii
2008-10-31 12:35 ` size of emacs executable after unicode merge Stephen Berman
2008-11-21 12:32 ` Kenichi Handa
2008-11-21 14:18 ` Ulrich Mueller
2008-10-31 10:41 ` YAMAMOTO Mitsuharu
2008-10-31 15:07 ` Dan Nicolaescu
2008-10-31 16:44 ` Stefan Monnier
2008-11-04 23:09 ` Chong Yidong
2008-11-05 4:17 ` Kenichi Handa
2008-11-05 15:50 ` Stefan Monnier
2008-11-06 7:56 ` Kenichi Handa
2008-11-08 2:42 ` Stefan Monnier
2008-11-08 4:10 ` Chong Yidong
2008-11-08 9:19 ` Eli Zaretskii
2008-11-09 0:27 ` Richard M. Stallman
2008-11-09 6:29 ` Dan Nicolaescu
2008-11-09 17:11 ` Richard M. Stallman
2008-11-10 1:24 ` Stefan Monnier
2008-11-10 1:55 ` Thomas Lord
2008-11-11 4:37 ` Chong Yidong
2008-11-08 10:30 ` Dan Nicolaescu
2008-11-09 20:14 ` Chong Yidong
2008-11-10 1:59 ` Kenichi Handa
2008-11-10 15:18 ` Chong Yidong
2008-11-10 23:18 ` Chong Yidong
2008-11-11 18:17 ` Chong Yidong
2008-11-12 6:26 ` Kenichi Handa
2008-11-13 16:33 ` Chong Yidong
2008-11-14 0:48 ` Kenichi Handa
2008-11-27 11:20 ` Kenichi Handa
2008-11-27 16:07 ` Chong Yidong
2008-11-27 16:12 ` Dan Nicolaescu
2008-11-28 1:02 ` Kenichi Handa
2008-11-27 16:31 ` Stefan Monnier
2008-11-27 20:17 ` Richard M Stallman
2008-11-27 20:42 ` Eli Zaretskii
2008-11-28 1:47 ` Kenichi Handa
2008-11-28 15:38 ` Richard M Stallman
2008-11-29 1:52 ` Kenichi Handa
2008-11-29 10:47 ` Eli Zaretskii
2008-11-29 19:43 ` Richard M Stallman
2008-11-30 4:50 ` Chetan Pandya
2008-11-28 16:11 ` Juanma Barranquero [this message]
2008-11-29 1:47 ` Kenichi Handa
2008-11-29 11:13 ` Juanma Barranquero
2008-11-29 12:17 ` Juanma Barranquero
2008-11-29 13:50 ` Kenichi Handa
2008-11-29 15:05 ` Juanma Barranquero
2008-11-05 22:30 ` Richard M. Stallman
2008-11-06 11:58 ` Kenichi Handa
2008-11-07 12:39 ` Richard M. Stallman
2008-11-07 13:29 ` Stephen J. Turnbull
2008-11-07 21:15 ` Richard M. Stallman
2008-11-08 4:00 ` Stephen J. Turnbull
2008-11-08 4:19 ` Stefan Monnier
2008-10-31 19:30 ` Richard M. Stallman
2008-11-09 22:43 ` Chong Yidong
2008-11-09 22:57 ` Chong Yidong
2008-11-10 1:28 ` Kenichi Handa
2008-11-10 19:29 ` Richard M. Stallman
2008-11-10 1:26 ` Kenichi Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7ccd24b0811280811k5996b24dla2a1692af64da2c9@mail.gmail.com \
--to=lekktu@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=handa@m17n.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).