[PATCH] array index bug in 'hangul.el'

[PATCH] array index bug in 'hangul.el'

[Jihyun Cho]

[-- Attachment #1: Type: text/plain, Size: 124 bytes --]

An out of range error occurs in 'hangul3-input-method-jong' function.
It's my mistake.
This patch adjust an index of array.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: hangul-array-index-bug.diff --]
[-- Type: text/x-diff; name=hangul-array-index-bug.diff, Size: 1205 bytes --]

? hangul-array-patch.diff
Index: emacs/leim/quail/hangul.el
===================================================================
RCS file: /sources/emacs/emacs/leim/quail/hangul.el,v
retrieving revision 1.23
diff -u -8 -p -r1.23 hangul.el
--- emacs/leim/quail/hangul.el	7 Jun 2008 12:42:33 -0000	1.23
+++ emacs/leim/quail/hangul.el	10 Aug 2008 05:11:37 -0000
@@ -328,17 +328,17 @@ Other parts are the same as a `hangul3-i
                         'jung
                         (aref hangul-queue 2)
                         (aref hangul-queue 3)))
                     (+ (aref hangul-queue 4)
                        (hangul-djamo
                         'jong
                         (aref hangul-queue 4)
                         char)))))
-             (aset hangul-queue 6 char)))
+             (aset hangul-queue 5 char)))
       (hangul-insert-character hangul-queue)
     (if (zerop (apply '+ (append hangul-queue nil)))
 	(hangul-insert-character (setq hangul-queue (vector 0 0 0 0 char 0)))
       (hangul-insert-character hangul-queue
 			       (setq hangul-queue (vector 0 0 0 0 char 0))))))
 
 (defun hangul-delete-backward-char ()
   "Delete the previous hangul character by Jaso units."

Re: [PATCH] array index bug in 'hangul.el'

[Juanma Barranquero]

On Sun, Aug 10, 2008 at 08:02, Jihyun Cho <jihyun.jo@gmail.com> wrote:

> This patch adjust an index of array.

Could you please add a suitable ChangeLog entry?

   Juanma

Re: [PATCH] array index bug in 'hangul.el'

[Kenichi Handa]

In article <9d644d9b0808092302g33d75c15l746d01d735d49130@mail.gmail.com>, "Jihyun Cho" <jihyun.jo@gmail.com> writes:

> An out of range error occurs in 'hangul3-input-method-jong' function.
> It's my mistake.
> This patch adjust an index of array.

Thank you.  I committed that change.

---
Kenichi Handa
handa@ni.aist.go.jp

Re: [PATCH] array index bug in 'hangul.el'

[Jihyun Cho]

2008/8/10, Juanma Barranquero <lekktu@gmail.com>:
> On Sun, Aug 10, 2008 at 08:02, Jihyun Cho <jihyun.jo@gmail.com> wrote:
>
> > This patch adjust an index of array.
>
> Could you please add a suitable ChangeLog entry?
>
>   Juanma
>

It is a simple bug.
An array size is 6. But I refer to the last element as 6.

Re: [PATCH] array index bug in 'hangul.el'

[Juanma Barranquero]

On Mon, Aug 11, 2008 at 02:29, Jihyun Cho <jihyun.jo@gmail.com> wrote:

> It is a simple bug.
> An array size is 6. But I refer to the last element as 6.

Patches for simple bugs also have ChangeLog entries... :-)

   Juanma

Re: [PATCH] array index bug in 'hangul.el'

[Kenichi Handa]

In article <9d644d9b0808101729l5b414df0i362c539f26ce41a6@mail.gmail.com>, "Jihyun Cho" <jihyun.jo@gmail.com> writes:

> 2008/8/10, Juanma Barranquero <lekktu@gmail.com>:
> > On Sun, Aug 10, 2008 at 08:02, Jihyun Cho <jihyun.jo@gmail.com> wrote:
> >
> > > This patch adjust an index of array.
> >
> > Could you please add a suitable ChangeLog entry?
> >
> >   Juanma
> >

> It is a simple bug.
> An array size is 6. But I refer to the last element as 6.

I committed the change with a proper ChangeLog entry.  But,
when you provide a patch next time, please add a ChangeLog
entry too.

---
Kenichi Handa
handa@ni.aist.go.jp

Re: [PATCH] array index bug in 'hangul.el'

[Jihyun Cho]

2008/8/11, Juanma Barranquero <lekktu@gmail.com>:
> On Mon, Aug 11, 2008 at 02:29, Jihyun Cho <jihyun.jo@gmail.com> wrote:
>
> > It is a simple bug.
> > An array size is 6. But I refer to the last element as 6.
>
> Patches for simple bugs also have ChangeLog entries... :-)
>
>   Juanma
>

Ok. I see.
When you type the Korean Jongseong, bug occurs.
So you can not type some characters in the Korean 3-Bulsik.
I fixed it.

Re: [PATCH] array index bug in 'hangul.el'

[Thien-Thi Nguyen]

() "Jihyun Cho" <jihyun.jo@gmail.com>
() Mon, 11 Aug 2008 10:15:55 +0900

   Ok. I see.
   When you type the Korean Jongseong, bug occurs.
   So you can not type some characters in the Korean 3-Bulsik.
   I fixed it.

Juanma is asking for a specific form of explanation, one that can
be prepended to the ChangeLog file.  In this case, it is best if
you respond like so:

|Here's a suitable ChangeLog entry:
|
|YYYY-MM-DD  Jihyun Cho  <jihyun.jo@gmail.com>  (tiny change)
|
|	* quail/hangul.el (hangul3-input-method-jong): Fix typo.

The asterisk, parens and colon are part of the ChangeLog format.
The filename is relative to the closest directory (traveling towards
the root) that contains a ChangeLog file.  The parenthesized symbol
indicates the top-level form where the change occurs.  The blurb
"Fix typo" describes the change.

In this way, you show good spirit by playing the maintainer's role.

thi

Re: [PATCH] array index bug in 'hangul.el'

[Jihyun Cho]

2008/8/11 Thien-Thi Nguyen <ttn@gnuvola.org>:
> () "Jihyun Cho" <jihyun.jo@gmail.com>
> () Mon, 11 Aug 2008 10:15:55 +0900
>
>   Ok. I see.
>   When you type the Korean Jongseong, bug occurs.
>   So you can not type some characters in the Korean 3-Bulsik.
>   I fixed it.
>
> Juanma is asking for a specific form of explanation, one that can
> be prepended to the ChangeLog file.  In this case, it is best if
> you respond like so:
>
> |Here's a suitable ChangeLog entry:
> |
> |YYYY-MM-DD  Jihyun Cho  <jihyun.jo@gmail.com>  (tiny change)
> |
> |       * quail/hangul.el (hangul3-input-method-jong): Fix typo.
>
> The asterisk, parens and colon are part of the ChangeLog format.
> The filename is relative to the closest directory (traveling towards
> the root) that contains a ChangeLog file.  The parenthesized symbol
> indicates the top-level form where the change occurs.  The blurb
> "Fix typo" describes the change.
>
> In this way, you show good spirit by playing the maintainer's role.
>
> thi
>

Aha. I'm sorry.
Next time, I will care about to add to a suitable ChangeLog.

Re: [PATCH] array index bug in 'hangul.el'

[Lennart Borgman (gmail)]

Jihyun Cho wrote:
> 2008/8/11 Thien-Thi Nguyen <ttn@gnuvola.org>:
>> () "Jihyun Cho" <jihyun.jo@gmail.com>
>> () Mon, 11 Aug 2008 10:15:55 +0900
>>
>>   Ok. I see.
>>   When you type the Korean Jongseong, bug occurs.
>>   So you can not type some characters in the Korean 3-Bulsik.
>>   I fixed it.
>>
>> Juanma is asking for a specific form of explanation, one that can
>> be prepended to the ChangeLog file.  In this case, it is best if
>> you respond like so:
>>
>> |Here's a suitable ChangeLog entry:
>> |
>> |YYYY-MM-DD  Jihyun Cho  <jihyun.jo@gmail.com>  (tiny change)
>> |
>> |       * quail/hangul.el (hangul3-input-method-jong): Fix typo.
>>
>> The asterisk, parens and colon are part of the ChangeLog format.
>> The filename is relative to the closest directory (traveling towards
>> the root) that contains a ChangeLog file.  The parenthesized symbol
>> indicates the top-level form where the change occurs.  The blurb
>> "Fix typo" describes the change.
>>
>> In this way, you show good spirit by playing the maintainer's role.
>>
>> thi
>>
> 
> Aha. I'm sorry.
> Next time, I will care about to add to a suitable ChangeLog.

Though something more informative than "fix typo" would perhaps be good 
in a change like this? With just this information I would assume that it 
was a typo in the doc string. Maybe

   Fix typo in index bound, replaced 6 by 5.

Re: [PATCH] array index bug in 'hangul.el'

[Thien-Thi Nguyen]

() "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>
() Mon, 11 Aug 2008 17:22:56 +0200

   Though something more informative than "fix typo"
   would perhaps be good in a change like this?

You're right.  "Fix typo" is lame.
I think the current entry is best:
"Fix array indexing bug."

thi