unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* New look for Emacs-23.0
@ 2008-06-28 15:46 Francesc Rocher
  2008-06-30 10:12 ` Juanma Barranquero
                   ` (4 more replies)
  0 siblings, 5 replies; 13+ messages in thread
From: Francesc Rocher @ 2008-06-28 15:46 UTC (permalink / raw)
  To: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 3349 bytes --]

Hi,

Please find attached a new set of splash images for Emacs-23.0. These
are anti-aliased versions of the current ones for Emacs and gnus. The
idea is that as font aliasing is a great improvement for next release,
I think that the visual and aesthetic aspect of Emacs should be also
slightly updated.

'splash.*' images should go to the 'etc/images/' directory; 'gnus.*'
images to 'etc/images/gnus/' ('svg' images are fully scalable and they
include copyright and licensing information; 'png' images were
directly obtained from the respective 'svg' images).

Below there are also a couple of patches, for files 'lisp/startup.el'
and 'lisp/gnus/gnus.el' files. These patches add support for 'svg' and
'png' image formats on those displays that support them. Otherwise,
current images are used ('xpm' or 'bmp' format, depending on the
display capabilities).

============================================================
--- startup.el.~1.493~  2008-06-28 16:48:37.000000000 +0200
+++ startup.el  2008-06-28 16:41:52.000000000 +0200
@@ -1375,13 +1375,17 @@
   "Insert the head part of the splash screen into the current buffer."
   (let* ((image-file (cond ((stringp fancy-splash-image)
                            fancy-splash-image)
-                          ((and (display-color-p)
-                                (image-type-available-p 'xpm))
-                            (if (and (fboundp 'x-display-planes)
-                                     (= (funcall 'x-display-planes) 8))
-                                "splash8.xpm"
-                              "splash.xpm"))
-                            (t "splash.pbm")))
+                          ((display-color-p)
+                                (cond ((image-type-available-p 'svg)
+                                                 "splash.svg")
+                                                ((image-type-available-p 'png)
+                                                 "splash.png")
+                                                ((image-type-available-p 'xpm)
+                                                 (if (and (fboundp
'x-display-planes)
+
   (= (funcall 'x-display-planes) 8))
+                                                               "splash8.xpm"
+                                                        "splash.xpm"))))
+                                       (t "splash.pbm")))
         (img (create-image image-file))
         (image-width (and img (car (image-size img))))
         (window-width (window-width (selected-window))))
============================================================
--- gnus.el.~1.71~      2008-06-18 22:25:47.000000000 +0200
+++ gnus.el     2008-06-28 16:43:40.000000000 +0200
@@ -1010,7 +1010,9 @@
                                    (symbol-value 'image-load-path))
                                   (t load-path)))
            (image (find-image
-                   `((:type xpm :file "gnus.xpm"
+                   `((:type svg :file "gnus.svg")
+                     (:type png :file "gnus.png")
+                     (:type xpm :file "gnus.xpm"
                             :color-symbols
                             (("thing" . ,(car gnus-logo-colors))
                              ("shadow" . ,(cadr gnus-logo-colors))
============================================================


Kind regards,
-- 
Francesc Rocher

[-- Attachment #2: splash.svg --]
[-- Type: image/svg+xml, Size: 31974 bytes --]

[-- Attachment #3: splash.png --]
[-- Type: image/png, Size: 39572 bytes --]

[-- Attachment #4: gnus.svg --]
[-- Type: image/svg+xml, Size: 15626 bytes --]

[-- Attachment #5: gnus.png --]
[-- Type: image/png, Size: 20051 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: New look for Emacs-23.0
  2008-06-28 15:46 New look for Emacs-23.0 Francesc Rocher
@ 2008-06-30 10:12 ` Juanma Barranquero
  2008-06-30 10:22   ` Werner LEMBERG
  2008-07-01 22:30 ` Leo
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 13+ messages in thread
From: Juanma Barranquero @ 2008-06-30 10:12 UTC (permalink / raw)
  To: Francesc Rocher; +Cc: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

> Please find attached a new set of splash images for Emacs-23.0. These
> are anti-aliased versions of the current ones for Emacs and gnus. The
> idea is that as font aliasing is a great improvement for next release,
> I think that the visual and aesthetic aspect of Emacs should be also
> slightly updated.

They are very nice and look much better that the default xpm splash
screen (at least on Windows).

  Juanma

[-- Attachment #2: comparison.png --]
[-- Type: image/png, Size: 24767 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: New look for Emacs-23.0
  2008-06-30 10:12 ` Juanma Barranquero
@ 2008-06-30 10:22   ` Werner LEMBERG
  2008-06-30 10:24     ` Miles Bader
  0 siblings, 1 reply; 13+ messages in thread
From: Werner LEMBERG @ 2008-06-30 10:22 UTC (permalink / raw)
  To: lekktu; +Cc: rocher, emacs-devel

> > Please find attached a new set of splash images for
> > Emacs-23.0. These are anti-aliased versions of the current ones
> > for Emacs and gnus. The idea is that as font aliasing is a great
> > improvement for next release, I think that the visual and
> > aesthetic aspect of Emacs should be also slightly updated.
> 
> They are very nice and look much better that the default xpm splash
> screen (at least on Windows).

A minor glitch: The lower left end of the `s' looks like a serifed
form which doesn't match the appearance of all other letters -- the
anti-aliased version pronouces this stronger than the old one.  With
other words, it shouldn't have a serif but rather a hook (like the
hook in the lower left of the `a').


    Werner




^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: New look for Emacs-23.0
  2008-06-30 10:22   ` Werner LEMBERG
@ 2008-06-30 10:24     ` Miles Bader
  0 siblings, 0 replies; 13+ messages in thread
From: Miles Bader @ 2008-06-30 10:24 UTC (permalink / raw)
  To: Werner LEMBERG; +Cc: lekktu, rocher, emacs-devel

Werner LEMBERG <wl@gnu.org> writes:
> A minor glitch: The lower left end of the `s' looks like a serifed
> form which doesn't match the appearance of all other letters -- the
> anti-aliased version pronouces this stronger than the old one.  With
> other words, it shouldn't have a serif but rather a hook (like the
> hook in the lower left of the `a').

I think it's fine.

-Miles

-- 
(\(\
(^.^)
(")")
*This is the cute bunny virus, please copy this into your sig so it can spread.




^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: New look for Emacs-23.0
  2008-06-28 15:46 New look for Emacs-23.0 Francesc Rocher
  2008-06-30 10:12 ` Juanma Barranquero
@ 2008-07-01 22:30 ` Leo
  2008-07-01 23:35 ` Chong Yidong
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 13+ messages in thread
From: Leo @ 2008-07-01 22:30 UTC (permalink / raw)
  To: emacs-devel

On 2008-06-28 16:46 +0100, Francesc Rocher wrote:
> Please find attached a new set of splash images for Emacs-23.0. These
> are anti-aliased versions of the current ones for Emacs and gnus. The
> idea is that as font aliasing is a great improvement for next release,
> I think that the visual and aesthetic aspect of Emacs should be also
> slightly updated.

Thank you for improving the look of Emacs.

-- 
.:  Leo  :.  [ sdl.web AT gmail.com ]  .:  [ GPG Key: 9283AA3F ]  :.

        Use the better alternative -- http://www.openoffice.org/





^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: New look for Emacs-23.0
  2008-06-28 15:46 New look for Emacs-23.0 Francesc Rocher
  2008-06-30 10:12 ` Juanma Barranquero
  2008-07-01 22:30 ` Leo
@ 2008-07-01 23:35 ` Chong Yidong
  2008-07-03 19:39 ` Dmitry Dzhus
  2008-07-03 21:55 ` Stefan Monnier
  4 siblings, 0 replies; 13+ messages in thread
From: Chong Yidong @ 2008-07-01 23:35 UTC (permalink / raw)
  To: emacs-devel; +Cc: Francesc Rocher

"Francesc Rocher" <rocher@member.fsf.org> writes:

> Please find attached a new set of splash images for Emacs-23.0. These
> are anti-aliased versions of the current ones for Emacs and gnus. The
> idea is that as font aliasing is a great improvement for next release,
> I think that the visual and aesthetic aspect of Emacs should be also
> slightly updated.

Looks fine to me.  Could someone help check this in?

Thanks.




^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: New look for Emacs-23.0
  2008-06-28 15:46 New look for Emacs-23.0 Francesc Rocher
                   ` (2 preceding siblings ...)
  2008-07-01 23:35 ` Chong Yidong
@ 2008-07-03 19:39 ` Dmitry Dzhus
  2008-07-03 21:55 ` Stefan Monnier
  4 siblings, 0 replies; 13+ messages in thread
From: Dmitry Dzhus @ 2008-07-03 19:39 UTC (permalink / raw)
  To: emacs-devel

Just to let you know, you might have used this SVG version:
http://commons.wikimedia.org/wiki/Image:Emacs-logo.svg. Looks a bit
tidier regarding some curves in the GNU head area. This logo may also be
found somewhere on gnu.org site already. Gnus logo is also available:
http://commons.wikimedia.org/wiki/Image:Gnus-logo.svg

--
С приветом





^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: New look for Emacs-23.0
  2008-06-28 15:46 New look for Emacs-23.0 Francesc Rocher
                   ` (3 preceding siblings ...)
  2008-07-03 19:39 ` Dmitry Dzhus
@ 2008-07-03 21:55 ` Stefan Monnier
  2008-07-07 21:28   ` Francesc Rocher
  4 siblings, 1 reply; 13+ messages in thread
From: Stefan Monnier @ 2008-07-03 21:55 UTC (permalink / raw)
  To: Francesc Rocher; +Cc: emacs-devel

> -                          ((and (display-color-p)
> -                                (image-type-available-p 'xpm))
> -                            (if (and (fboundp 'x-display-planes)
> -                                     (= (funcall 'x-display-planes) 8))
> -                                "splash8.xpm"
> -                              "splash.xpm"))
> -                            (t "splash.pbm")))
> +                          ((display-color-p)
> +                                (cond ((image-type-available-p 'svg)
> +                                                 "splash.svg")
> +                                                ((image-type-available-p 'png)
> +                                                 "splash.png")
> +                                                ((image-type-available-p 'xpm)
> +                                                 (if (and (fboundp
> 'x-display-planes)
> +
>    (= (funcall 'x-display-planes) 8))
> +                                                               "splash8.xpm"
> +                                                        "splash.xpm"))))
> +                                       (t "splash.pbm")))

This code still needs to be tuned to correctly pay attention to the
color depth: testing display-planes only when we don't support SVG and
PNG doesn't make any sense.


        Stefan




^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: New look for Emacs-23.0
  2008-07-03 21:55 ` Stefan Monnier
@ 2008-07-07 21:28   ` Francesc Rocher
  2008-07-08  1:24     ` Stefan Monnier
  0 siblings, 1 reply; 13+ messages in thread
From: Francesc Rocher @ 2008-07-07 21:28 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

On Thu, Jul 3, 2008 at 11:55 PM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
>>    (= (funcall 'x-display-planes) 8))
>> +                                                               "splash8.xpm"
>> +                                                        "splash.xpm"))))
>> +                                       (t "splash.pbm")))
>
> This code still needs to be tuned to correctly pay attention to the
> color depth: testing display-planes only when we don't support SVG and
> PNG doesn't make any sense.
>

May be what's wrong is that 'x-display-planes' is used to test whether
'splash8.xpm' or 'splash.xpm' must be displayed. I think it's wrong
because both images are not so different. Judging by the name of these
images, I did suppose they had different color depth. Surprisingly,
I've found this:

splash.xpm
**************************************************
static char *splash[] = {
/* width height num_colors chars_per_pixel */
"   270   217        4            1",
/* colors */
". c None",
"# c #c64e3b",
"a c #000000",
"c c #2076c1",
**************************************************

splash8.xpm
**************************************************
static char * splash_xpm[] = {
"270 217 4 1",
" 	c None",
".	c #C64E3B",
"+	c #000000",
"@	c #2076C1",
**************************************************

So, in terms of color depth, what's the difference between these images?


Best regards,
-- 
Francesc Rocher




^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: New look for Emacs-23.0
  2008-07-07 21:28   ` Francesc Rocher
@ 2008-07-08  1:24     ` Stefan Monnier
  2008-07-16  9:56       ` Francesc Rocher
  0 siblings, 1 reply; 13+ messages in thread
From: Stefan Monnier @ 2008-07-08  1:24 UTC (permalink / raw)
  To: Francesc Rocher; +Cc: emacs-devel

> May be what's wrong is that 'x-display-planes' is used to test whether
> 'splash8.xpm' or 'splash.xpm' must be displayed. I think it's wrong
> because both images are not so different. Judging by the name of these
> images, I did suppose they had different color depth. Surprisingly,
> I've found this:

Indeed, I also saw that the 2 images are low-color versions, so the test
didn't make much sense, but the situation now is very different because
the new files use up many colors, so the display-depth should be used to
guard the use of those new high-color images.


        Stefan




^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: New look for Emacs-23.0
  2008-07-08  1:24     ` Stefan Monnier
@ 2008-07-16  9:56       ` Francesc Rocher
  2008-07-16 16:22         ` Stefan Monnier
  0 siblings, 1 reply; 13+ messages in thread
From: Francesc Rocher @ 2008-07-16  9:56 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

> Indeed, I also saw that the 2 images are low-color versions, so the test
> didn't make much sense, but the situation now is very different because
> the new files use up many colors, so the display-depth should be used to
> guard the use of those new high-color images.

You're right, so my proposal is to use the following patch and to delete the
file 'splash8.xpm' from the repository.

-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----
--- startup.el.~1.495~  2008-07-16 10:17:39.000000000 +0200
+++ startup.el  2008-07-16 10:53:20.000000000 +0200
@@ -1443,13 +1443,15 @@
                            fancy-splash-image)
                           ((display-color-p)
-                           (cond ((image-type-available-p 'svg)
+                           (cond ((<= (display-planes) 8)
+                                  (if (image-type-available-p 'xpm)
+                                      "splash.xpm"
+                                    "splash.pbm"))
+                                 ((image-type-available-p 'svg)
                                   "splash.svg")
                                  ((image-type-available-p 'png)
                                   "splash.png")
                                  ((image-type-available-p 'xpm)
-                                  (if (and (fboundp 'x-display-planes)
-                                           (= (funcall 'x-display-planes) 8))
-                                      "splash8.xpm"
-                                    "splash.xpm"))))
+                                  "splash.xpm")
+                                 (t "splash.pbm")))
                           (t "splash.pbm")))
         (img (create-image image-file))
-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----

-- Francesc Rocher




^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: New look for Emacs-23.0
  2008-07-16  9:56       ` Francesc Rocher
@ 2008-07-16 16:22         ` Stefan Monnier
  2008-07-18 14:25           ` Juanma Barranquero
  0 siblings, 1 reply; 13+ messages in thread
From: Stefan Monnier @ 2008-07-16 16:22 UTC (permalink / raw)
  To: Francesc Rocher; +Cc: emacs-devel

>> Indeed, I also saw that the 2 images are low-color versions, so the test
>> didn't make much sense, but the situation now is very different because
>> the new files use up many colors, so the display-depth should be used to
>> guard the use of those new high-color images.

> You're right, so my proposal is to use the following patch and to delete the
> file 'splash8.xpm' from the repository.

That sounds good.  Can someone make this change?


        Stefan




^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: New look for Emacs-23.0
  2008-07-16 16:22         ` Stefan Monnier
@ 2008-07-18 14:25           ` Juanma Barranquero
  0 siblings, 0 replies; 13+ messages in thread
From: Juanma Barranquero @ 2008-07-18 14:25 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Francesc Rocher, emacs-devel

> That sounds good.  Can someone make this change?

Done.

  Juanma




^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2008-07-18 14:25 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-28 15:46 New look for Emacs-23.0 Francesc Rocher
2008-06-30 10:12 ` Juanma Barranquero
2008-06-30 10:22   ` Werner LEMBERG
2008-06-30 10:24     ` Miles Bader
2008-07-01 22:30 ` Leo
2008-07-01 23:35 ` Chong Yidong
2008-07-03 19:39 ` Dmitry Dzhus
2008-07-03 21:55 ` Stefan Monnier
2008-07-07 21:28   ` Francesc Rocher
2008-07-08  1:24     ` Stefan Monnier
2008-07-16  9:56       ` Francesc Rocher
2008-07-16 16:22         ` Stefan Monnier
2008-07-18 14:25           ` Juanma Barranquero

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).