From: "Juanma Barranquero" <lekktu@gmail.com>
To: "Stefan Monnier" <monnier@iro.umontreal.ca>
Cc: Adrian Robert <arobert@interstitiality.net>,
emacs- devel <emacs-devel@gnu.org>
Subject: Re: "Pager" page-up and -down, why not merge?
Date: Thu, 5 Jun 2008 00:09:12 +0200 [thread overview]
Message-ID: <f7ccd24b0806041509l7d351e8ft6abb2e1c7c873850@mail.gmail.com> (raw)
In-Reply-To: <jwvod6hw7mh.fsf-monnier+emacs@gnu.org>
> In what way is it different from setting scroll-preserve-screen-position?
It preserves the column, too, which is the whole point of pager.el.
> I suggest we reuse temporary-goal-column instead.
>> (defconst pager-keep-column-commands
>> '(pager-row-down pager-row-up row-dn row-up
>> pager-page-down pager-page-up pg-dn pg-up)
>> "Commands which when called without any other intervening command should
>> keep the `pager-temporary-goal-column'")
>
> What are those extra commands?
pager-row-* are scrolling commands, not needed in Emacs (which has
scroll-lock-mode). pg-dn, pg-up, etc. are aliases for pager 1.0
compatibility.
> Since this doesn't doesn't use scroll-up or scroll-down, it's very much
> unclear whether it's going to behave sufficiently well in all cases.
>
> I'm especially uncomfortable with the use of vertical-motion, which
> doesn't actually use the redisplay's code, but some approximation of its
> behavior, (so it doesn't pay attention to images and other things like
> that, for example).
The original pager.el, which I'm using, does not use
`vertical-motion', but `forward-line', `scroll-down' and `scroll-up'.
Please take a look at http://user.it.uu.se/~mic/pager.el
> PS: Here's a patch to window.c which makes
> scroll-preserve-screen-position preserve the column position as well as
> the line position, tho it only applies to GUI frames, not to tty frames
> (which use another piece of code which I haven't bothered to adjust
> accordingly).
That is a great change, please install it!
Juanma
next prev parent reply other threads:[~2008-06-04 22:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-03 20:57 "Pager" page-up and -down, why not merge? Adrian Robert
2008-06-04 11:13 ` Richard M Stallman
2008-06-04 12:29 ` Adrian Robert
2008-06-04 13:46 ` Juanma Barranquero
2008-06-05 12:36 ` Richard M Stallman
2008-06-05 13:09 ` Juanma Barranquero
2008-06-04 16:14 ` Stefan Monnier
2008-06-04 22:09 ` Juanma Barranquero [this message]
2008-06-04 23:55 ` Adrian Robert
2008-06-05 3:58 ` Stefan Monnier
2008-06-06 13:24 ` Adrian Robert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7ccd24b0806041509l7d351e8ft6abb2e1c7c873850@mail.gmail.com \
--to=lekktu@gmail.com \
--cc=arobert@interstitiality.net \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).