From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Juanma Barranquero" Newsgroups: gmane.emacs.devel Subject: Re: Adding parameters to windows Date: Wed, 4 Jun 2008 23:13:06 +0200 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1212614003 22016 80.91.229.12 (4 Jun 2008 21:13:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Jun 2008 21:13:23 +0000 (UTC) Cc: joakim@verona.se, emacs-devel@gnu.org To: "Stefan Monnier" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 04 23:14:05 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K40J2-0002K1-17 for ged-emacs-devel@m.gmane.org; Wed, 04 Jun 2008 23:14:04 +0200 Original-Received: from localhost ([127.0.0.1]:57450 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K40IF-0006Ta-Fe for ged-emacs-devel@m.gmane.org; Wed, 04 Jun 2008 17:13:15 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K40IA-0006RV-T8 for emacs-devel@gnu.org; Wed, 04 Jun 2008 17:13:10 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K40I8-0006OP-OY for emacs-devel@gnu.org; Wed, 04 Jun 2008 17:13:09 -0400 Original-Received: from [199.232.76.173] (port=35120 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K40I8-0006O5-JN for emacs-devel@gnu.org; Wed, 04 Jun 2008 17:13:08 -0400 Original-Received: from py-out-1112.google.com ([64.233.166.176]:8547) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K40I8-0008Qs-6S for emacs-devel@gnu.org; Wed, 04 Jun 2008 17:13:08 -0400 Original-Received: by py-out-1112.google.com with SMTP id p76so212048pyb.1 for ; Wed, 04 Jun 2008 14:13:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=4S+Lfi+CV8w+vjIGTOjwD9TWzF9HGFVYeJakqHuOX7k=; b=WQnPL+ZXlFeHUg9P3EMQuRTiB1KEcx5DRHayX+JFeEXQ464ibaV2PM0+6PcLhi1L7e DZ1zdcQj/BaYyB8gNys387byhqfE43H5tnhiVMheeDafHXeP4dwgW62t8mYKsNLxH8r8 xLMctoCaccci89RLfyXErqgkGTtFU/Ac4mYYA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=gHrzvh3ckd393XlNjn+PVA2Ulfh0NFu8E3GHTWiN82pCfaEMSK9p4ptHJIHcbsUwsU NaRG9nSlj2iJ54VFvW8yD196AMevclu25KYpt7XBkMRqMnUuun8DSVPF0Jr/2OLwfGPI fxSdwX7GKQ/jyrl3vQkWh5XpRGNEjIXRtBq18= Original-Received: by 10.114.197.1 with SMTP id u1mr708231waf.75.1212613987033; Wed, 04 Jun 2008 14:13:07 -0700 (PDT) Original-Received: by 10.114.167.17 with HTTP; Wed, 4 Jun 2008 14:13:06 -0700 (PDT) In-Reply-To: Content-Disposition: inline X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:98424 Archived-At: On Wed, Jun 4, 2008 at 5:10 PM, Stefan Monnier wrote: > Can someone fix up those things and commit this patch, please? I commited it. I've done a few trivial changes: - making the argument of `window-parameters' optional, as the docstring suggests - args are consistently called WINDOW, PARAMETER and VALUE. - I've documented the return value of `set-window-parameter' (seems silly to return it and not document it). Questions: - What does mean "The meaningful PARAMETERs depend on the kind of window." Which parameters are meaningul, and for which windows? - It is wise to return (in `window-parameter' and `set-window-parameter') directly the parameter alist, instead of a copy of it? > And add a note to etc/NEWS about it? Sorry, I'm *horrible* at deciding what to write in NEWS... Juanma