From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Juanma Barranquero" Newsgroups: gmane.emacs.devel Subject: Re: Emacs pretest 22.1.91 Date: Wed, 27 Feb 2008 16:49:59 +0100 Message-ID: References: <87ejb8vl0i.fsf@stupidchicken.com> <47C55A60.5010709@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1204127431 1126 80.91.229.12 (27 Feb 2008 15:50:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 Feb 2008 15:50:31 +0000 (UTC) Cc: Eli Zaretskii , matsuan@ca2.so-net.ne.jp, emacs-devel@gnu.org To: "Jason Rumney" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 27 16:50:48 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JUOYQ-0004N5-Io for ged-emacs-devel@m.gmane.org; Wed, 27 Feb 2008 16:50:46 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JUOXu-0004qN-Fv for ged-emacs-devel@m.gmane.org; Wed, 27 Feb 2008 10:50:14 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JUOXm-0004oo-Se for emacs-devel@gnu.org; Wed, 27 Feb 2008 10:50:06 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JUOXi-0004ls-UM for emacs-devel@gnu.org; Wed, 27 Feb 2008 10:50:06 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JUOXi-0004lh-JF for emacs-devel@gnu.org; Wed, 27 Feb 2008 10:50:02 -0500 Original-Received: from wa-out-1112.google.com ([209.85.146.182]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JUOXh-0005SW-2V for emacs-devel@gnu.org; Wed, 27 Feb 2008 10:50:01 -0500 Original-Received: by wa-out-1112.google.com with SMTP id k34so3334131wah.10 for ; Wed, 27 Feb 2008 07:49:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=KAr3ywbfQPsWxITBPTjXxNvv/D02wIwPBdRbGBIrQz0=; b=XU/1UjaIrJOEK3wo5HIrx7Tm3Ak1sOHrDGDzb/E02gMGS2XJBDu79pyeu6zC23kIlwE+RHt66IqcicnBJhGX9mkPV7UkqFouwntchoeYlUKYrXS0FzFNEsfPEkWZDAz/qV41ImxYaIwXxiAi6ZJA+GWYGB3frv+yMYSi4eM4+Yc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=eLJ/X8UxrEVifXxHrK9KbEwMykZXFW98Aax4BFLnVz4DlPqp1vUvTzv35rU54+QKnrEqUmVL9cpZ9bZoee+RkAvvh2p1PSbBYPcjvkmpaBGZutjUTGqGX18f/zKxhHD9mXxGNsCnYROB0iDTtCXx/ssIONn9kmPrDbiTZW7B1lU= Original-Received: by 10.114.39.16 with SMTP id m16mr7557095wam.146.1204127399822; Wed, 27 Feb 2008 07:49:59 -0800 (PST) Original-Received: by 10.115.72.13 with HTTP; Wed, 27 Feb 2008 07:49:59 -0800 (PST) In-Reply-To: Content-Disposition: inline X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:90612 Archived-At: On Wed, Feb 27, 2008 at 3:11 PM, Juanma Barranquero wrote: > OK, what about this simpler change then? > 2008-02-27 Juanma Barranquero > > * faces.el (x-create-frame-with-faces): Delay call to > `tool-bar-setup' if invoked before loading the init files. What a nice can of worms. After the patch above, with this simple .emacs: ;;;;;;;;;; emacs.el ;;;;;;;;;; (with-temp-buffer (compilation-mode 1)) ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; you get an error: signal(wrong-type-argument (keymapp nil)) define-key-after(nil [previous-error-no-select] (menu-item "previous-error-no-select" previous-error-no-select :image (image :type xpm :file "c:/emacs/trunk/etc/images/left-arrow.xpm") :rtl "right-arrow" :help "Goto previous error")) tool-bar-local-item("left-arrow" previous-error-no-select previous-error-no-select nil :rtl "right-arrow" :help "Goto previous error") byte-code(...) (compilation-mode 1) [... etc ] That's because compile.el (on the trunk) has (defvar compilation-mode-tool-bar-map (if (display-graphic-p) (let ((map (butlast (copy-keymap tool-bar-map))) ... But before calling `tool-bar-setup', `tool-bar-map' contains just '(keymap)). This is not a new bug; if you add the tool-bar stuff from the trunk's compile.el to the EMACS22_BASE compile.el. it fails too. It just hadn't been noticed before. The only way out I can see right now is promoting `tool-bar-setup' to be a user (or at least, package-developer) visible function. For example, to change the above code to (defvar compilation-mode-tool-bar-map (when (display-graphic-p) (tool-bar-setup) (let ((map (butlast (copy-keymap tool-bar-map))) ... I'm feeling deeply unclean right now. Juanma