From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Juanma Barranquero" Newsgroups: gmane.emacs.devel Subject: Re: vc-find-root and nonexistent drives Date: Sat, 16 Feb 2008 19:12:19 +0100 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1203185560 16146 80.91.229.12 (16 Feb 2008 18:12:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 16 Feb 2008 18:12:40 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Eli Zaretskii" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 16 19:13:02 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JQRX1-00062S-Ki for ged-emacs-devel@m.gmane.org; Sat, 16 Feb 2008 19:12:59 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JQRWX-0006qb-6p for ged-emacs-devel@m.gmane.org; Sat, 16 Feb 2008 13:12:29 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JQRWS-0006p5-Li for emacs-devel@gnu.org; Sat, 16 Feb 2008 13:12:24 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JQRWQ-0006lf-Hx for emacs-devel@gnu.org; Sat, 16 Feb 2008 13:12:23 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JQRWQ-0006lU-Ba for emacs-devel@gnu.org; Sat, 16 Feb 2008 13:12:22 -0500 Original-Received: from wa-out-1112.google.com ([209.85.146.177]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JQRWQ-0000TT-7j for emacs-devel@gnu.org; Sat, 16 Feb 2008 13:12:22 -0500 Original-Received: by wa-out-1112.google.com with SMTP id k34so1989546wah.10 for ; Sat, 16 Feb 2008 10:12:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=XzeF6oBNpMyN6i0HvTfjDqD3OIfiCDEzxLHrbEW0+Ps=; b=FVTBo+NCCTTpXK8rWR6t5dOJIKFCYpjuTcTUKW8/Clv9MF/5wxVWZBidfhLhvlUwL4ptxiLv4k5djiJJrjTXMXitqFSFN2zsm9oHK1UcH10ygqCm/ogG7iIVDBtwBXkTnLaYcBqsrp3HwQQds/Spjx90yCUx+3T5HDg+Z+rMpcQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=rsFtL31Y8xf1YDse0R1SZv8y2HjObfH3RBDfsMG7Wr60ApTbeUnUAI5prOi+lw2pGXQP/iA0t6Zpk6C39kNGOrTmYsr8IWdOe0eGD21J5GYLr9EOrSwncgVyK3uGggdsCFD5t8kfkJklETbLPUHr/yIXc5mAIk1G4CpC+M0o55Y= Original-Received: by 10.114.209.1 with SMTP id h1mr4488063wag.130.1203185539766; Sat, 16 Feb 2008 10:12:19 -0800 (PST) Original-Received: by 10.115.72.13 with HTTP; Sat, 16 Feb 2008 10:12:19 -0800 (PST) In-Reply-To: Content-Disposition: inline X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:89264 Archived-At: On Feb 16, 2008 2:43 PM, Eli Zaretskii wrote: > So how about changing the loop condition to > > (while (and (not (file-directory-p file)) (file-exists-p file)) > > ? Yes, you're right. On one hand, I don't like much touching VC code; on the other, I wrote my message at 04:52am, which means that, at that moment, I wasn't aware of `file-exists-p' (I fell asleep over my keyboard once or twice before that) :) I'm checking your fix in the EMACS_22_BASE branch. Juanma