unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Juanma Barranquero" <lekktu@gmail.com>
To: "Eli Zaretskii" <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: vc-find-root and nonexistent drives
Date: Sat, 16 Feb 2008 19:12:19 +0100	[thread overview]
Message-ID: <f7ccd24b0802161012n19717d8eh8e498bd70c87bee7@mail.gmail.com> (raw)
In-Reply-To: <uk5l5kodl.fsf@gnu.org>

On Feb 16, 2008 2:43 PM, Eli Zaretskii <eliz@gnu.org> wrote:

> So how about changing the loop condition to
>
>   (while (and (not (file-directory-p file)) (file-exists-p file))
>
> ?

Yes, you're right. On one hand, I don't like much touching VC code; on
the other, I wrote my message at 04:52am, which means that, at that
moment, I wasn't aware of `file-exists-p' (I fell asleep over my
keyboard once or twice before that) :)

I'm checking your fix in the EMACS_22_BASE branch.

             Juanma




  reply	other threads:[~2008-02-16 18:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-16  3:52 vc-find-root and nonexistent drives Juanma Barranquero
2008-02-16 13:43 ` Eli Zaretskii
2008-02-16 18:12   ` Juanma Barranquero [this message]
2008-02-16 20:16     ` Stefan Monnier
2008-02-16 20:18       ` Juanma Barranquero
2008-02-16 14:29 ` Stefan Monnier
2008-02-16 18:09   ` Juanma Barranquero
2008-02-16 20:33     ` Stefan Monnier
2008-02-16 20:46       ` Juanma Barranquero
2008-02-17  4:18       ` Eli Zaretskii
2008-02-17 19:00         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7ccd24b0802161012n19717d8eh8e498bd70c87bee7@mail.gmail.com \
    --to=lekktu@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).