INSTALL recommends libungif library

INSTALL recommends libungif library

[Ulrich Mueller]

The INSTALL file in the CVS trunk still recommends using libungif.
I guess that this library is replaced by giflib on most distros.
Also, the Sourceforge project page for libungif does no longer exist.

While it is o.k. for configure to support both libraries as
alternatives, the INSTALL file should recommend giflib. A patch is
included below.

Ulrich


--- INSTALL	5 Feb 2008 03:56:41 -0000	1.129
+++ INSTALL	5 Feb 2008 15:06:12 -0000
@@ -139,10 +139,7 @@
                       Get version 6b -- 6a is reported to fail in
                       Emacs.
   . libtiff for TIFF: http://www.libtiff.org/
-  . libungif for GIF:
-      http://sourceforge.net/projects/libungif
-      Ensure you get version 4.1.0b1 or higher of libungif -- a bug in
-      4.1.0 can crash Emacs.
+  . libgif for GIF:   http://sourceforge.net/projects/giflib/
 
 Emacs will configure itself to build with these libraries if the
 `configure' script finds them on your system, unless you supply the

Re: INSTALL recommends libungif library

[Juanma Barranquero]

On Feb 5, 2008 4:22 PM, Ulrich Mueller <ulm@gentoo.org> wrote:

> While it is o.k. for configure to support both libraries as
> alternatives, the INSTALL file should recommend giflib. A patch is
> included below.

Committed.

Thanks,

             Juanma

Re: INSTALL recommends libungif library

[Ulrich Mueller]

>>>>> On Tue, 5 Feb 2008, Juanma Barranquero wrote:

>> While it is o.k. for configure to support both libraries as
>> alternatives, the INSTALL file should recommend giflib. A patch is
>> included below.

> Committed.

... on the EMACS_22_BASE branch, where configure still asks for
libungif unconditionally.

So either the updated INSTALL file should go to the trunk only, or the
Emacs 22 configure.in should be updated (the latter making more sense,
in my opinion).

Ulrich

Re: INSTALL recommends libungif library

[Juanma Barranquero]

On Feb 5, 2008 7:16 PM, Ulrich Mueller <ulm@gentoo.org> wrote:

> ... on the EMACS_22_BASE branch, where configure still asks for
> libungif unconditionally.

Oops.

> So either the updated INSTALL file should go to the trunk only, or the
> Emacs 22 configure.in should be updated (the latter making more sense,
> in my opinion).

No, I don't think the pretest is the right moment to be changing
configure.in... I'll move the change to the trunk.

Thanks,

             Juanma

Re: INSTALL recommends libungif library

[Ulrich Mueller]

>>>>> On Tue, 5 Feb 2008, Juanma Barranquero wrote:

>> So either the updated INSTALL file should go to the trunk only, or the
>> Emacs 22 configure.in should be updated (the latter making more sense,
>> in my opinion).

> No, I don't think the pretest is the right moment to be changing
> configure.in...

So, maybe now? 22.2 is released.

Ulrich