Re: [Emacs-diffs] Changes to emacs/lisp/help-fns.el,v

Re: [Emacs-diffs] Changes to emacs/lisp/help-fns.el,v

[Juanma Barranquero]

On 11/10/07, Martin Rudalics <rudalics@gmx.at> wrote:

> CVSROOT:        /sources/emacs
> Module name:    emacs
> Changes by:     Martin Rudalics <m061211>       07/11/10 09:58:35
>
> Index: help-fns.el

C-h f car [RET] => "Wrong type argument: stringp, t"
C-h v * [RET] => "Wrong type argument: stringp, t"

The error happens in (with-current-buffer standard-output ...) because
standard-output is not bound to buffer *Help*, like it was before.

             Juanma

Re: [Emacs-diffs] Changes to emacs/lisp/help-fns.el,v

[martin rudalics]

 > C-h f car [RET] => "Wrong type argument: stringp, t"
 > C-h v * [RET] => "Wrong type argument: stringp, t"
 >
 > The error happens in (with-current-buffer standard-output ...) because
 > standard-output is not bound to buffer *Help*, like it was before.

I can't reproduce that.  Does it help when you remake the autoloads?
`with-output-to-temp-buffer' had the argument (help-buffer) here which
should evaluate to *Help*.  Can you understand why it doesn't in your
case?

Re: [Emacs-diffs] Changes to emacs/lisp/help-fns.el,v

[Juanma Barranquero]

On 11/10/07, martin rudalics <rudalics@gmx.at> wrote:

> I can't reproduce that.  Does it help when you remake the autoloads?

Now, this is weird. The bug was present after several rounds of "make
cvs-update" (which does the recompile and autoload targets, among
other things) followed by "make install".

However, it has disappeared after manually recompiling help-fns.el...

             Juanma

Re: [Emacs-diffs] Changes to emacs/lisp/help-fns.el,v

[martin rudalics]

 > Now, this is weird. The bug was present after several rounds of "make
 > cvs-update" (which does the recompile and autoload targets, among
 > other things) followed by "make install".

I never do that but if it recompiles before making the autoloads,
wouldn't that fail?  `help-buffer' is in help-mode.el but was not
autoloaded before, probably because only `with-output-to-temp-buffer'
needed it (I fail to understand how that worked).  I'm reluctant to put
any requires in help.el (it used to require `view-mode' once) to avoid
recursing.  If you have any suggestions ...

 > However, it has disappeared after manually recompiling help-fns.el...

Does that mean you still see it with `describe-char' or `describe-face'?
Or did you recompile them too?

Re: [Emacs-diffs] Changes to emacs/lisp/help-fns.el,v

[Juanma Barranquero]

On 11/11/07, martin rudalics <rudalics@gmx.at> wrote:

> I never do that but if it recompiles before making the autoloads,
> wouldn't that fail?  `help-buffer' is in help-mode.el but was not
> autoloaded before, probably because only `with-output-to-temp-buffer'
> needed it (I fail to understand how that worked).

Aha.

> Does that mean you still see it with `describe-char' or `describe-face'?

I still saw it with describe-key. At that point I bootstrapped ;)

             Juanma

Re: [Emacs-diffs] Changes to emacs/lisp/help-fns.el,v

[Robert J. Chassell]

    C-h f car [RET] => "Wrong type argument: stringp, t"

I got that, but then I rebuilt Emacs using `make clean' and `make
bootstrap' (which I try to avoid since it takes me so long) and now my
`emacs -Q -D' works fine.  Now, I get the proper result for `car'.

  Today's GNU Emacs CVS snapshot, Sat, 2007 Nov 10  20:05 UTC
  GNU Emacs 23.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.12.1)

-- 
    Robert J. Chassell                          GnuPG Key ID: 004B4AC8
    bob@rattlesnake.com                         bob@gnu.org
    http://www.rattlesnake.com                  http://www.teak.cc

Re: [Emacs-diffs] Changes to emacs/lisp/help-fns.el,v

[martin rudalics]

 >     C-h f car [RET] => "Wrong type argument: stringp, t"
 >
 > I got that, but then I rebuilt Emacs using `make clean' and `make
 > bootstrap' (which I try to avoid since it takes me so long) and now my
 > `emacs -Q -D' works fine.  Now, I get the proper result for `car'.

In fact `make bootstrap' is what I tested before checking this in - it
takes more than an hour on my system.  Sorry for the inconvenience.