* [herring@lanl.gov: Re: desktop.el ugliness]
@ 2007-07-13 18:38 Richard Stallman
0 siblings, 0 replies; 3+ messages in thread
From: Richard Stallman @ 2007-07-13 18:38 UTC (permalink / raw)
To: emacs-devel
Would someone please install this in Emacs 22 and the trunk,
then ack?
------- Start of forwarded message -------
X-Spam-Status: No, score=-0.0 required=5.0 tests=SPF_PASS autolearn=failed
version=3.1.0
In-Reply-To: <E1I968r-0002z2-AO@fencepost.gnu.org>
Date: Thu, 12 Jul 2007 15:29:07 -0700 (PDT)
Subject: Re: desktop.el ugliness
From: "Davis Herring" <herring@lanl.gov>
To: "Richard Stallman" <rms@gnu.org>
Cc: emacs-devel@gnu.org
Reply-To: herring@lanl.gov
MIME-Version: 1.0
Content-Type: text/plain;charset=iso-8859-1
> desktop-buffer-info refers to the free variable dirname, which comes
> from desktop-save. Would someone please clean that up?
> Then please ack.
Sorry; `desktop-buffer-info' was once a lambda in `desktop-save', and I
didn't think to separate it cleanly. Here's a trivial patch which also
corrects the handling of relative names in `desktop-save'.
Davis
2007-07-12 Davis Herring <herring@lanl.gov>
* desktop.el (desktop-buffer-info, desktop-save): Use
`desktop-dirname' instead of `dirname'.
*** desktop.el 12 Jul 2007 16:23:06 -0600 1.112
- --- desktop.el 12 Jul 2007 16:25:35 -0600
***************
*** 652,658 ****
(set-buffer buffer)
(list
;; basic information
! (desktop-file-name (buffer-file-name) dirname)
(buffer-name)
major-mode
;; minor modes
- --- 652,658 ----
(set-buffer buffer)
(list
;; basic information
! (desktop-file-name (buffer-file-name) desktop-dirname)
(buffer-name)
major-mode
;; minor modes
***************
*** 673,679 ****
buffer-read-only
;; auxiliary information
(when (functionp desktop-save-buffer)
! (funcall desktop-save-buffer dirname))
;; local variables
(let ((locals desktop-locals-to-save)
(loclist (buffer-local-variables))
- --- 673,679 ----
buffer-read-only
;; auxiliary information
(when (functionp desktop-save-buffer)
! (funcall desktop-save-buffer desktop-dirname))
;; local variables
(let ((locals desktop-locals-to-save)
(loclist (buffer-local-variables))
***************
*** 896,902 ****
(insert "\n " (desktop-value-to-string e)))
(insert ")\n\n")))
! (setq default-directory dirname)
(let ((coding-system-for-write 'emacs-mule))
(write-region (point-min) (point-max) (desktop-full-file-name) nil
'nomessage))
;; We remember when it was modified (which is presumably just now).
- --- 896,902 ----
(insert "\n " (desktop-value-to-string e)))
(insert ")\n\n")))
! (setq default-directory desktop-dirname)
(let ((coding-system-for-write 'emacs-mule))
(write-region (point-min) (point-max) (desktop-full-file-name) nil
'nomessage))
;; We remember when it was modified (which is presumably just now).
------- End of forwarded message -------
^ permalink raw reply [flat|nested] 3+ messages in thread
* [herring@lanl.gov: Re: desktop.el ugliness]
@ 2007-07-21 4:51 Richard Stallman
2007-07-26 13:18 ` Juanma Barranquero
0 siblings, 1 reply; 3+ messages in thread
From: Richard Stallman @ 2007-07-21 4:51 UTC (permalink / raw)
To: emacs-devel
[I sent this message a week ago but did not get a response.]
Would someone please install this in Emacs 22 and the trunk,
then ack?
------- Start of forwarded message -------
X-Spam-Status: No, score=-0.0 required=5.0 tests=SPF_PASS autolearn=failed
version=3.1.0
In-Reply-To: <E1I968r-0002z2-AO@fencepost.gnu.org>
Date: Thu, 12 Jul 2007 15:29:07 -0700 (PDT)
Subject: Re: desktop.el ugliness
From: "Davis Herring" <herring@lanl.gov>
To: "Richard Stallman" <rms@gnu.org>
Cc: emacs-devel@gnu.org
Reply-To: herring@lanl.gov
MIME-Version: 1.0
Content-Type: text/plain;charset=iso-8859-1
> desktop-buffer-info refers to the free variable dirname, which comes
> from desktop-save. Would someone please clean that up?
> Then please ack.
Sorry; `desktop-buffer-info' was once a lambda in `desktop-save', and I
didn't think to separate it cleanly. Here's a trivial patch which also
corrects the handling of relative names in `desktop-save'.
Davis
2007-07-12 Davis Herring <herring@lanl.gov>
* desktop.el (desktop-buffer-info, desktop-save): Use
`desktop-dirname' instead of `dirname'.
*** desktop.el 12 Jul 2007 16:23:06 -0600 1.112
- --- desktop.el 12 Jul 2007 16:25:35 -0600
***************
*** 652,658 ****
(set-buffer buffer)
(list
;; basic information
! (desktop-file-name (buffer-file-name) dirname)
(buffer-name)
major-mode
;; minor modes
- --- 652,658 ----
(set-buffer buffer)
(list
;; basic information
! (desktop-file-name (buffer-file-name) desktop-dirname)
(buffer-name)
major-mode
;; minor modes
***************
*** 673,679 ****
buffer-read-only
;; auxiliary information
(when (functionp desktop-save-buffer)
! (funcall desktop-save-buffer dirname))
;; local variables
(let ((locals desktop-locals-to-save)
(loclist (buffer-local-variables))
- --- 673,679 ----
buffer-read-only
;; auxiliary information
(when (functionp desktop-save-buffer)
! (funcall desktop-save-buffer desktop-dirname))
;; local variables
(let ((locals desktop-locals-to-save)
(loclist (buffer-local-variables))
***************
*** 896,902 ****
(insert "\n " (desktop-value-to-string e)))
(insert ")\n\n")))
! (setq default-directory dirname)
(let ((coding-system-for-write 'emacs-mule))
(write-region (point-min) (point-max) (desktop-full-file-name) nil
'nomessage))
;; We remember when it was modified (which is presumably just now).
- --- 896,902 ----
(insert "\n " (desktop-value-to-string e)))
(insert ")\n\n")))
! (setq default-directory desktop-dirname)
(let ((coding-system-for-write 'emacs-mule))
(write-region (point-min) (point-max) (desktop-full-file-name) nil
'nomessage))
;; We remember when it was modified (which is presumably just now).
------- End of forwarded message -------
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [herring@lanl.gov: Re: desktop.el ugliness]
2007-07-21 4:51 [herring@lanl.gov: Re: desktop.el ugliness] Richard Stallman
@ 2007-07-26 13:18 ` Juanma Barranquero
0 siblings, 0 replies; 3+ messages in thread
From: Juanma Barranquero @ 2007-07-26 13:18 UTC (permalink / raw)
To: rms; +Cc: emacs-devel
On 7/21/07, Richard Stallman <rms@gnu.org> wrote:
> [I sent this message a week ago but did not get a response.]
>
> Would someone please install this in Emacs 22 and the trunk,
> then ack?
It is already installed. I forgot to ack.
Juanma
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-26 13:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-21 4:51 [herring@lanl.gov: Re: desktop.el ugliness] Richard Stallman
2007-07-26 13:18 ` Juanma Barranquero
-- strict thread matches above, loose matches on Subject: below --
2007-07-13 18:38 Richard Stallman
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).