From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Juanma Barranquero" Newsgroups: gmane.emacs.devel Subject: Re: Re[2]: Strange behaviour after Show/Hide Speedbar in Emacs 22.1 Date: Tue, 26 Jun 2007 00:46:52 +0200 Message-ID: References: <200706251317.l5PDH7J1011619@projectile.siege-engine.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1182811624 18659 80.91.229.12 (25 Jun 2007 22:47:04 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 25 Jun 2007 22:47:04 +0000 (UTC) Cc: Angelo.Graziosi@roma1.infn.it, emacs-devel@gnu.org To: "Eric M. Ludlam" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 26 00:47:02 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1I2xKl-0003ei-Fq for ged-emacs-devel@m.gmane.org; Tue, 26 Jun 2007 00:46:59 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I2xKl-0007WZ-DY for ged-emacs-devel@m.gmane.org; Mon, 25 Jun 2007 18:46:59 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1I2xKi-0007WU-LV for emacs-devel@gnu.org; Mon, 25 Jun 2007 18:46:56 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1I2xKg-0007WF-4C for emacs-devel@gnu.org; Mon, 25 Jun 2007 18:46:55 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I2xKf-0007WC-V1 for emacs-devel@gnu.org; Mon, 25 Jun 2007 18:46:53 -0400 Original-Received: from wx-out-0506.google.com ([66.249.82.234]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1I2xKf-0000h3-Fw for emacs-devel@gnu.org; Mon, 25 Jun 2007 18:46:53 -0400 Original-Received: by wx-out-0506.google.com with SMTP id h26so1646530wxd for ; Mon, 25 Jun 2007 15:46:52 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=kyM6z/DKXZsXpLkcp0HS38/QPH0NMRevcV8qYWzuOYI9fZqWq4BOpANvxVNs/L/UD/Y5UqCMHimljXjxImjVYAMHwCiyqjVjzMjqmurOBep2bN/1sK4mcAYD3wNcNzJDvKAleAqW/nS/br1/c0eqojrsfYKBUCkzbST9zYHu9r4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=uZrJIqB82VuTLYi/6qIHSqZpjCJ9PeWe2yCmYu23G+F7CQCjaTMcb/rTml2IF28xHPph/amZmMyBJUYe8u+u0NSk9WfujeWBMMc4/dqkmugsa3EqRf4ETHRG+nKTnjMbOZkERL/48XWPrM68NQgJPa45aMfdM+k6VJuFKqIP8Pk= Original-Received: by 10.90.104.14 with SMTP id b14mr4847900agc.1182811612555; Mon, 25 Jun 2007 15:46:52 -0700 (PDT) Original-Received: by 10.90.87.8 with HTTP; Mon, 25 Jun 2007 15:46:52 -0700 (PDT) In-Reply-To: <200706251317.l5PDH7J1011619@projectile.siege-engine.com> Content-Disposition: inline X-detected-kernel: Linux 2.4-2.6 (Google crawlbot) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:73869 Archived-At: On 6/25/07, Eric M. Ludlam wrote: > I suspect your patch might leave a bunch of invisible frames about, > but it's been a while since I've been in that code so I'm not sure. At the very least, this patch should be committed. There's no point in trying to delete-frame nil. OTOH, I confess I don't entirely understand the way speedbar handles frames. For example: emacs -q M-x speedbar-frame-mode "q" on the speedbar frame M-: (frame-list) => the speedbar frame still exists but emacs -q C-x 5 2 M-x speedbar-frame-mode "q" on the speedbar frame M-: (frame-list) => the speedbar frame does not exist ?? Juanma Index: lisp/speedbar.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/speedbar.el,v retrieving revision 1.87 diff -u -2 -r1.87 speedbar.el --- lisp/speedbar.el 19 Feb 2007 13:37:23 -0000 1.87 +++ lisp/speedbar.el 25 Jun 2007 22:39:43 -0000 @@ -1054,7 +1054,8 @@ If the deleted frame is the frame SPEEDBAR is attached to, we need to delete speedbar also." - (let ((frame-to-be-deleted (car (car (cdr e))))) - (if (eq frame-to-be-deleted dframe-attached-frame) - (delete-frame speedbar-frame))) + (when speedbar-frame + (let ((frame-to-be-deleted (car (car (cdr e))))) + (if (eq frame-to-be-deleted dframe-attached-frame) + (delete-frame speedbar-frame)))) )