unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Juanma Barranquero" <lekktu@gmail.com>
Subject: momentary-string-display
Date: Wed, 27 Dec 2006 02:18:29 +0100	[thread overview]
Message-ID: <f7ccd24b0612261718y74ac1f6eo1f5706f5f6f39fc1@mail.gmail.com> (raw)

`momentary-string-display' is a little weird function, or at least it
*acts* a little weird in my tests:

  1) It does not check that POS is valid.

  2) It does not check whether POS satisfies any restriction, nor uses
`widen' and `save-restriction' to circumvent it.

  3) Its docstring says: "Momentarily display STRING in the buffer at
POS.", which could be taken as this being valid:

  (momentary-string-display "test"
                            (with-current-buffer MY-BUFFER
                              (point-marker)))

   which isn't; the buffer temporarily modified is (current-buffer),
not MY-BUFFER.

  4) From its docstring, it seems as if STRING should always be
displayed, which isn't true (STRING is only shown when POS and point
both can be simultaneously displayed on the window).

Worse yet, in cases 1) to 3), `momentary-string-display' can err out
after displaying STRING, leaving the buffer modified and with
`buffer-file-name' set to nil.

                    /L/e/k/t/u

             reply	other threads:[~2006-12-27  1:18 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-27  1:18 Juanma Barranquero [this message]
2006-12-27 21:16 ` momentary-string-display Richard Stallman
2006-12-27 23:53   ` momentary-string-display Juanma Barranquero
2006-12-29 15:44     ` momentary-string-display Richard Stallman
2007-01-02 23:58       ` momentary-string-display Juanma Barranquero
2006-12-29  4:47   ` momentary-string-display Kevin Rodgers
2006-12-29 22:58     ` momentary-string-display Richard Stallman
2007-01-03  8:53       ` momentary-string-display Kevin Rodgers
2007-01-04  1:41         ` momentary-string-display Stephen Leake
2007-01-04  2:31         ` momentary-string-display Richard Stallman
2007-01-04 15:31           ` momentary-string-display Kevin Rodgers
2007-01-04 22:34             ` momentary-string-display Richard Stallman
2007-01-04 23:18               ` momentary-string-display Juanma Barranquero
2007-01-05 19:09                 ` momentary-string-display Richard Stallman
2007-01-05  7:05               ` momentary-string-display Stephen Leake
2007-01-06  2:54                 ` momentary-string-display Richard Stallman
2007-01-06  7:36                   ` momentary-string-display Stephen Leake
2007-01-07  3:47                     ` momentary-string-display Richard Stallman
2007-01-07 14:41                       ` momentary-string-display Stephen Leake
2007-01-02 22:54   ` momentary-string-display Tak Ota
2007-01-03 21:11     ` momentary-string-display Richard Stallman
2007-01-03 21:36       ` momentary-string-display Tak Ota

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7ccd24b0612261718y74ac1f6eo1f5706f5f6f39fc1@mail.gmail.com \
    --to=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).