unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Juanma Barranquero" <lekktu@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] Changes to emacs/lib-src/makefile.w32-in,v
Date: Mon, 27 Nov 2006 17:20:55 +0100	[thread overview]
Message-ID: <f7ccd24b0611270820xd672103rc96f48bcddabcf8b@mail.gmail.com> (raw)
In-Reply-To: <ufyc4zxfb.fsf@gnu.org>

On 11/27/06, Eli Zaretskii <eliz@gnu.org> wrote:

> That'd be a nuisance, I think: people run configure even if
> makefile.w32-in didn't change (well, I do), just to be sure.

The only (tiny) problem with depending on makefile.w32-in, is that if
the user forgets to run configure, he will see emacsclient being
compiled, but the version number will still be old. It's a bit
misleading.

Just a nitpick, anyway. The main case to consider is whether users
(not developers building from the CVS tree) will get the right number
after bootstrapping the first time, and they will.

> What you are actually saying is that makefile in each directory should
> depend on the respective makefile.w32-in, and if the latter was
> changed, nt/configure.bat should run automatically.

A rule in makefile making it depend on makefile.w32-in? Nice idea :)

> You are probably
> right, but let's not do this before the release.

No, of course not!

> (While at that, we should also avoid recreating makefile's and other
> files produced by nt/configure.bat if the new version would be
> identical to the old one, to avoid unnecessary recompilation.)

That shouldn't be too tricky, if you can count on a reliable way to
compare the old and new files. (Do we require diff right now? I don't
think so.)

                    /L/e/k/t/u

  reply	other threads:[~2006-11-27 16:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1GoaVP-0003Nb-Cp@savannah.gnu.org>
2006-11-27  9:42 ` [Emacs-diffs] Changes to emacs/lib-src/makefile.w32-in,v Juanma Barranquero
2006-11-27 13:33   ` Eli Zaretskii
2006-11-27 13:56     ` Juanma Barranquero
2006-11-27 15:49   ` Juanma Barranquero
2006-11-27 16:06     ` Eli Zaretskii
2006-11-27 16:20       ` Juanma Barranquero [this message]
2006-11-28  4:10         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7ccd24b0611270820xd672103rc96f48bcddabcf8b@mail.gmail.com \
    --to=lekktu@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).