From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Juanma Barranquero" Newsgroups: gmane.emacs.devel Subject: Re: [sa2c@sa2c.net: pp-eval-last-sexp() does not eval last sexp] Date: Fri, 3 Nov 2006 17:04:07 +0100 Message-ID: References: <1162563696.6360.1.camel@ramprasad> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1162569904 7224 80.91.229.2 (3 Nov 2006 16:05:04 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 3 Nov 2006 16:05:04 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 03 17:04:58 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Gg1Wu-0002xM-TL for ged-emacs-devel@m.gmane.org; Fri, 03 Nov 2006 17:04:29 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gg1Wu-0001dp-GH for ged-emacs-devel@m.gmane.org; Fri, 03 Nov 2006 11:04:28 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Gg1Wg-0001aq-3V for emacs-devel@gnu.org; Fri, 03 Nov 2006 11:04:14 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Gg1Wb-0001Lk-Cd for emacs-devel@gnu.org; Fri, 03 Nov 2006 11:04:13 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gg1Wb-0001LU-5Z for emacs-devel@gnu.org; Fri, 03 Nov 2006 11:04:09 -0500 Original-Received: from [66.249.92.171] (helo=ug-out-1314.google.com) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Gg1Wa-0001rV-J8 for emacs-devel@gnu.org; Fri, 03 Nov 2006 11:04:08 -0500 Original-Received: by ug-out-1314.google.com with SMTP id j3so496000ugf for ; Fri, 03 Nov 2006 08:04:07 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=meacfSotBMYeHJLQW1LgcVYoZHtZssZDaPbUrxiZnf40FAiO6X0tnza+xpm2w/cH4TQchaw+FlNUEKn+4t5hJP5Yhs9+W+A6otNkODgQRZJjM9Pu+cW2dYvZou+Xn4/0Nb/9HnMAX9lQSTfVlJ5uqiZWRJk+LtywvbgpEp7MJ5M= Original-Received: by 10.82.179.9 with SMTP id b9mr810493buf.1162569847295; Fri, 03 Nov 2006 08:04:07 -0800 (PST) Original-Received: by 10.82.136.11 with HTTP; Fri, 3 Nov 2006 08:04:07 -0800 (PST) Original-To: Ramprasad In-Reply-To: <1162563696.6360.1.camel@ramprasad> Content-Disposition: inline X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:61705 Archived-At: On 11/3/06, Ramprasad wrote: > Done ! Thanks for committing these patches. Note, however, that you put the changelog entry for lib-src/Makefile.in into lisp/ChangeLog, and that all three entries had problems: - lib-src/Makefile.in: It didn't mention where was INSTALL_SCRIPT used. - lisp/sort.el: It didn't mention `sort-columns', where the change had happened. - emacs-lisp/pp.el: It referenced `pp-eval-expression', but the change is in `pp-eval-last-sexp'. Moreover, the filename was lisp/emacs-lisp/pp.el (they should be relative from the directory where the ChangeLog file resides). All this makes me think you don't know about `add-change-log-entry-other-window' (bound to C-x 4 a), which I recommend. Thanks, /L/e/k/t/u