unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* ChangeLog for tumme.el
@ 2006-02-07 10:26 Juanma Barranquero
  2006-02-07 12:37 ` Mathias Dahl
  0 siblings, 1 reply; 4+ messages in thread
From: Juanma Barranquero @ 2006-02-07 10:26 UTC (permalink / raw)
  Cc: Mathias Dahl

tumme.el is lacking ChangeLog entries both for the addition of the
file, and a +144-37 lines change from yesterday.

Another thing: shouldn't the docstring for
`tumme-copy-with-exif-file-name' be a little less coloquial?

--
                    /L/e/k/t/u

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: ChangeLog for tumme.el
  2006-02-07 10:26 ChangeLog for tumme.el Juanma Barranquero
@ 2006-02-07 12:37 ` Mathias Dahl
  2006-02-07 15:12   ` Juanma Barranquero
  2006-02-07 15:17   ` Jason Rumney
  0 siblings, 2 replies; 4+ messages in thread
From: Mathias Dahl @ 2006-02-07 12:37 UTC (permalink / raw)


Juanma Barranquero <lekktu@gmail.com> writes:

> tumme.el is lacking ChangeLog entries both for the addition of the
> file, and a +144-37 lines change from yesterday.

With the help of what you and David sent, I am sure I will figure this
out, tonight.

> Another thing: shouldn't the docstring for
> `tumme-copy-with-exif-file-name' be a little less coloquial?

`colloquial', yes. (I had to look that word up) I get the point. There
are probably more docstrings whose colloquiality should be
questioned. :) I will try to make it better.

I guess this particular command's usefulness could be questioned
though. I used it each time I fetch the images from my digital camera,
but maybe it is a command I should only keep a local copy of?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: ChangeLog for tumme.el
  2006-02-07 12:37 ` Mathias Dahl
@ 2006-02-07 15:12   ` Juanma Barranquero
  2006-02-07 15:17   ` Jason Rumney
  1 sibling, 0 replies; 4+ messages in thread
From: Juanma Barranquero @ 2006-02-07 15:12 UTC (permalink / raw)
  Cc: emacs-devel

On 2/7/06, Mathias Dahl <brakjoller@gmail.com> wrote:

> `colloquial', yes. (I had to look that word up)

It's a reasonably common word in Spanish (and with a single "l" ;)

> I get the point. There
> are probably more docstrings whose colloquiality should be
> questioned. :) I will try to make it better.

It was not a comment aimed at you specifically, of course. I was just
thinking of not-totally-useful docstrings. As an example, in
net/newsticker.el there's an internal function
`newsticker--buffer-redraw' whose docstring says:

  "Sometimes (CVS) Emacs forgets to update the window..."

That shouldn't be a comment, I think, but a bug report. And
`newsticker--insert-image' says:

  "[...] This is a work-around for a strange behavior of Emacs
versions before 21.3.50. [...]"

I don't think mentioning 21.3.50 (which is not an official release of
Emacs) in a docstring is a good idea.

> I guess this particular command's usefulness could be questioned
> though. I used it each time I fetch the images from my digital camera,
> but maybe it is a command I should only keep a local copy of?

Perhaps, I don't know. But if it stays, definitely the docstring
should be more general.

--
                    /L/e/k/t/u

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: ChangeLog for tumme.el
  2006-02-07 12:37 ` Mathias Dahl
  2006-02-07 15:12   ` Juanma Barranquero
@ 2006-02-07 15:17   ` Jason Rumney
  1 sibling, 0 replies; 4+ messages in thread
From: Jason Rumney @ 2006-02-07 15:17 UTC (permalink / raw)
  Cc: emacs-devel


> I guess this particular command's usefulness could be questioned
> though. I used it each time I fetch the images from my digital camera,
> but maybe it is a command I should only keep a local copy of?
>   
It looks quite useful to me. Maybe the design of the feature needs to be 
more flexible though in case users want to include other EXIF fields in 
the name, or want shorter names without the time etc. Probably a format 
string of some sort would be welcome.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2006-02-07 15:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-07 10:26 ChangeLog for tumme.el Juanma Barranquero
2006-02-07 12:37 ` Mathias Dahl
2006-02-07 15:12   ` Juanma Barranquero
2006-02-07 15:17   ` Jason Rumney

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).